Skip to content

Conversation

@cjyetman
Copy link
Member

following #248

@cjyetman cjyetman requested a review from jacobvjk as a code owner June 23, 2025 08:24
@cjyetman cjyetman requested review from Copilot and jdhoffa June 23, 2025 08:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow to require R 4.1 as the minimum version in development tests, aligning with issue #248.

  • Bumps the lowest R version in the CI matrix from 4.0 to 4.1.

@jdhoffa
Copy link
Member

jdhoffa commented Jun 23, 2025

Lots of failing checks here 😅

@cjyetman
Copy link
Member Author

Lots of failing checks here 😅

yeah, until #231 is merged... a bit circular, #231 will fail one of the dev tests until this merges, and this will fail basically all tests till #231 merges, so 🤷🏻

@jdhoffa
Copy link
Member

jdhoffa commented Jun 23, 2025

Makes sense. Will merge #231 first in that case.

@jdhoffa
Copy link
Member

jdhoffa commented Jun 23, 2025

Ah nevermind, I see it's already merged.

@github-actions
Copy link

R CMD check CRAN incoming feasibility check notes found:

Found the following (possibly) invalid URLs:
  URL: https://rmi-pacta.r-universe.dev/pacta.loanbook
    From: README.md
    Status: 404
    Message: Not Found
  URL: https://www.transitionmonitor.com/
    From: man/abcd_demo.Rd
          man/co2_intensity_scenario_demo.Rd
          man/gics_classification.Rd
          man/isic_classification.Rd
          man/loanbook_demo.Rd
          man/nace_classification.Rd
          man/naics_classification.Rd
          man/overwrite_demo.Rd
          man/psic_classification.Rd
          man/region_isos_demo.Rd
          man/scenario_demo_2020.Rd
          man/sector_classifications.Rd
          man/sic_classification.Rd
    Status: Error
    Message: libcurl error code 28:
      	Failed to connect to www.transitionmonitor.com port 443 after 21040 ms: Could not connect to server

@github-actions
Copy link

github-actions bot commented Jun 23, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-23 09:00 UTC

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO GREEN

@cjyetman cjyetman merged commit 3bc1e65 into main Jun 23, 2025
20 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch June 23, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants