Skip to content

Conversation

@AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Nov 3, 2024

Close #97

PA2024-centric

Checks that an entity within a Real Estate "report type" (executive summary, participant, portfolio) has a "portfolio type" (Direct, mortgage) before processing.

This is primarily to handle an extra empty array that has shown up unexpectedly in the final results. By checking for the portfolio_type object, and skipping if it's not there, we can bypass this extra empty list.

@codecov
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.80%. Comparing base (eb22d8f) to head (f4ce355).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/create_interactive_report.R 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #98      +/-   ##
========================================
- Coverage   0.80%   0.80%   -0.01%     
========================================
  Files         25      25              
  Lines       1617    1619       +2     
========================================
  Hits          13      13              
- Misses      1604    1606       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm marked this pull request as ready for review November 4, 2024 09:31
@AlexAxthelm AlexAxthelm requested a review from MonikaFu as a code owner November 4, 2024 09:31
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexAxthelm AlexAxthelm merged commit 5f002dc into main Nov 4, 2024
9 checks passed
@AlexAxthelm AlexAxthelm deleted the 97-extra-re-array branch November 4, 2024 10:57
@jdhoffa
Copy link
Member

jdhoffa commented Nov 4, 2024

Wait did the CI build and run successfully?

@AlexAxthelm
Copy link
Collaborator Author

All of the docker-relevent parts have. Final confirmation just kicked off https://github.com/RMI-PACTA/workflow.transition.monitor/actions/runs/11662856598 (after pointing back to main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Real Estate file handline cannot handle actual reports.json

4 participants