Skip to content

Conversation

@AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Nov 25, 2024

Exporting choose_dictionary_language in support of RMI-PACTA/workflow.pacta.dashboard#21

While I was touching the function, reworked it to not use dplyr::transmute, which has been superseded (now relies only on base:: functions), add tests, and some checks for validity prior to processing.

Side effect: now emits a data.frame(), rather than tibble if data is a tibble.

Most likely the first of several PRs to export functions that are needed in workflow.pacta.dashboard

@AlexAxthelm AlexAxthelm changed the title Choose dictionary language update and export choose_dictionary_language Nov 25, 2024
@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.96%. Comparing base (5f002dc) to head (714bdbe).

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #99      +/-   ##
========================================
+ Coverage   0.80%   1.96%   +1.15%     
========================================
  Files         25      25              
  Lines       1619    1631      +12     
========================================
+ Hits          13      32      +19     
+ Misses      1606    1599       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm marked this pull request as ready for review November 25, 2024 16:45
@AlexAxthelm
Copy link
Collaborator Author

Closing in favor of refactoring to new package.

@AlexAxthelm AlexAxthelm deleted the choose_dictionary_language branch November 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants