Skip to content

replace Roxygen template with inline function #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

replace Roxygen template with inline function #611

merged 4 commits into from
Mar 27, 2025

Conversation

@cjyetman
Copy link
Member

@cjyetman cjyetman commented Mar 26, 2025

@cjyetman cjyetman requested a review from MonikaFu as a code owner March 26, 2025 10:39
@cjyetman cjyetman requested a review from jdhoffa March 26, 2025 10:42
MonikaFu
MonikaFu approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjyetman cjyetman merged commit 214de7a into main Mar 27, 2025
30 checks passed
@cjyetman cjyetman deleted the replace-roxygen-template branch March 27, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MonikaFu MonikaFu MonikaFu approved these changes

@jdhoffa jdhoffa Awaiting requested review from jdhoffa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

using @template and @templateVars is superseded and no longer recommended

3 participants

@cjyetman @MonikaFu