wip - add automotive to WEO2024 #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker build status
|
cjyetman
reviewed
Jul 29, 2025
| weo_2024_fig_chptr_3_raw_filename: "WEO2024_Figures_Chapter_03.xlsx" | ||
| iea_global_ev_raw_path: "iea_global_ev_2024" | ||
| iea_global_ev_raw_filename: "IEA Global EV Data 2024.csv" | ||
| weo_2024_fig_chptr_3_raw_full_filepath: 'weo_2024/WEO2024 extended data/WEO2024_Figures_Chapter_03.xlsx' |
Member
There was a problem hiding this comment.
in this config, I strive to always separate paths from filenames, which has organizational impact later on in the scripts
cjyetman
reviewed
Jul 29, 2025
| iea_global_ev_raw_filename: "electric-vehicle-sales-by-region-and-scenario-2030-and-2035.xlsx" | ||
| mpp_ats_raw_path: "mpp_ats-20240227" | ||
| mpp_ats_raw_filename: "2022-08-12 - MPP ATS - RPK and GHG intensity.xlsx" | ||
| hybrid_methodology: "hybrid_in_ev" |
Member
There was a problem hiding this comment.
is this a filename, path, or something else?
cjyetman
reviewed
Jul 29, 2025
| readr::read_csv( | ||
| file = iea_global_ev_2024_raw_full_filepath, | ||
| show_col_types = FALSE | ||
| read_xlsx( |
Member
There was a problem hiding this comment.
prefer explicit name spacing, e.g.
Suggested change
| read_xlsx( | |
| readxl::read_xlsx( |
cjyetman
reviewed
Jul 29, 2025
| show_col_types = FALSE | ||
| read_xlsx( | ||
| path = iea_global_ev_2024_raw_full_filepath, | ||
| sheet = "electric-vehicle-sales-by-regio" |
Member
There was a problem hiding this comment.
is it intentional that the sheet name ends with "regio" not "region"?
Contributor
Author
There was a problem hiding this comment.
sheet name is truncated when uploading data from IEA website, so sheet name title will be electric-vehicle-sales-by-regio
cjyetman
reviewed
Jul 29, 2025
Comment on lines
+84
to
+93
| iea_sales_share_ev <- read_xlsx( | ||
| path = iea_global_ev_2024_raw_full_filepath, | ||
| sheet = "electric vehicle share-ev" | ||
| ) | ||
|
|
||
| iea_sales_share_bev_phev <- read_xlsx( | ||
| path = iea_global_ev_2024_raw_full_filepath, | ||
| sheet = "electric-vehicle-share-bev-phev" | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
prefer explicit name spacing, e.g.
Suggested change
| iea_sales_share_ev <- read_xlsx( | |
| path = iea_global_ev_2024_raw_full_filepath, | |
| sheet = "electric vehicle share-ev" | |
| ) | |
| iea_sales_share_bev_phev <- read_xlsx( | |
| path = iea_global_ev_2024_raw_full_filepath, | |
| sheet = "electric-vehicle-share-bev-phev" | |
| ) | |
| iea_sales_share_ev <- readxl::read_xlsx( | |
| path = iea_global_ev_2024_raw_full_filepath, | |
| sheet = "electric vehicle share-ev" | |
| ) | |
| iea_sales_share_bev_phev <- readxl::read_xlsx( | |
| path = iea_global_ev_2024_raw_full_filepath, | |
| sheet = "electric-vehicle-share-bev-phev" | |
| ) | |
cjyetman
reviewed
Jul 29, 2025
|
|
||
| weo_2024 <- | ||
| pacta.scenario.data.preparation::prepare_weo_2024_scenario( | ||
| prepare_weo_2024_scenario( |
Member
There was a problem hiding this comment.
prefer explicit name spacing, e.g.
Suggested change
| prepare_weo_2024_scenario( | |
| pacta.scenario.data.preparation::prepare_weo_2024_scenario( |
Contributor
Author
|
closed as duplicated of #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to adapt codeines from weo2023 to change in data format in weo2024