Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes support for Open Babel from the spyrmsd library, focusing exclusively on RDKit for molecule I/O operations. The change is motivated by Open Babel being abandoned, particularly on the Python side.
- Removed the entire
spyrmsd/optional/obabel.pymodule - Updated import logic to only use RDKit for molecular operations
- Removed the
molformat()utility function that was specific to Open Babel
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
spyrmsd/optional/obabel.py |
Deleted entire Open Babel integration module |
spyrmsd/io.py |
Simplified import logic to only try RDKit, removed nested fallback |
spyrmsd/utils.py |
Removed molformat() function used for Open Babel format conversion |
spyrmsd/optional/rdkit.py |
Changed from utils.molformat() to utils.format(), updated docstring reference |
spyrmsd/molecule.py |
Removed from_obabel() class method, updated docstring |
spyrmsd/__main__.py |
Updated error message to only mention RDKit requirement |
setup.py |
Removed openbabel from extras_require |
tests/test_utils.py |
Removed test_molformat() test function |
tests/test_molecule.py |
Removed test_from_obmol() test function |
docs/source/tutorials/tutorial.rst |
Updated to remove Open Babel references, changed section headings |
docs/source/tutorials/tutorial.ipynb |
Updated notebook to remove Open Babel references |
docs/source/installation.rst |
Removed Open Babel from installation instructions |
docs/source/api/*.rst |
Standardized order of autodoc directives, removed obabel module docs |
devtools/conda-envs/*.yaml |
Removed Open Babel test environments and dependency |
.github/workflows/pytest.yml |
Removed Open Babel from test matrix |
.github/workflows/pre-commit.yml |
Updated Python version matrix |
README.md |
Updated to remove Open Babel references |
CHANGELOG.md |
Added entry for Open Babel removal |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #149. Open Babel seems to be abandoned, especially from the Python side.
Checklist