[Plugin][CI/CD] establish CI/CD and add workflow for ATOM OOT#301
[Plugin][CI/CD] establish CI/CD and add workflow for ATOM OOT#301zejunchen-zejun wants to merge 15 commits intoROCm:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds unit tests around ATOM’s vLLM plugin mode to validate environment-flag behavior, registry/platform wiring, config translation, and upstream vLLM import-path guardrails.
Changes:
- Add guardrail test that imports the vLLM symbols/paths relied on by ATOM plugin mode.
- Add unit tests for plugin-mode framework state, env-flag disable/fallback behavior, and platform registration.
- Add unit tests for vLLM→ATOM config translation and unsupported model architecture rejection.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/plugin/test_plugin_vllm_import_paths.py | Guardrail coverage for upstream vLLM import paths used by ATOM plugin integration |
| tests/plugin/test_plugin_unsupported_models.py | Verifies unsupported model architectures are rejected by the wrapper |
| tests/plugin/test_plugin_registries.py | Tests vLLM platform registration path and disable switch |
| tests/plugin/test_plugin_mode_status.py | Tests plugin/server mode detection and framework switching |
| tests/plugin/test_plugin_env_flags.py | Tests env-flag precedence and attention-backend fallback behavior |
| tests/plugin/test_plugin_config_translation.py | Tests translating vLLM config objects into ATOM Config in plugin mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zejunchen-zejun
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zejunchen-zejun
force-pushed
the
zejun/add_oot_ut
branch
from
ed539fb to
0f7ec53
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zejunchen-zejun
force-pushed
the
zejun/add_oot_ut
branch
from
0f7ec53 to
cac46a5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zejunchen-zejun
force-pushed
the
zejun/add_oot_ut
branch
from
59fa022 to
59d1170
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zejunchen-zejun
changed the title
zejunchen-zejun
changed the title
zejunchen-zejun
force-pushed
the
zejun/add_oot_ut
branch
from
21d04b1 to
b1bc429
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zejunchen-zejun
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for OOT Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
zejunchen-zejun
force-pushed
the
zejun/add_oot_ut
branch
from
94e8c9b to
5fa84b6
Compare
|
Close this PR as it is not from the un-forked repo, so the docker release action cannot be triggered. |
Design: #255 (comment)