[Dialect] Add FP8 support to GFX120X WMMA atom - #1074
Open
big-yellow-duck wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The GFX120X WMMA atom added in #943 currently exposes the RDNA4 wave32 FP16 and BF16 paths, but not the hardware FP8 path. As a result, FlyDSL kernels targeting gfx1200/gfx1201 cannot use the regular MMA atom API for E4M3FN WMMA and must bypass it with a raw ROCDL operation.
This completes the floating-point surface of the existing GFX120X atom by adding E4M3FN inputs with FP32 accumulation.
Technical Details
f8E4M3FN x f8E4M3FN -> f32for the GFX120X16x16x16WMMA atom.rocdl.wmma.f32.16x16x16.fp8_fp8.vector<2xi32>.16x16x16, matched operand types, FP32 accumulation, and no floating-point sign/clamp controls.This is compiler/atom support only. Optimized block-scaled GEMM kernels and shape routing are intentionally left for a separate follow-up.
Test Plan
cmake --build build-fly -j2.fly-optandFileCheck.fly-optandFileCheck.pytest -q tests/kernels/test_rdna4_wmma_atom.pyon gfx1201.git diff --check.Test Result
Submission Checklist