-
Notifications
You must be signed in to change notification settings - Fork 87
[HIPIFY][SWDEV-490433][fix] Add support for cuda-samples helper headers to HIP #1962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HIPIFY][SWDEV-490433][fix] Add support for cuda-samples helper headers to HIP #1962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please regenerate hipify-perl and docs according to the instructions and add them to this PR. The needed tests I'll add in a separate PR.
Could you also provide here the statistics on CUDA Samples where helper includes are not provided explicitly in the sources? It is needed to figure out the necessity for implementing nvcc's behaviour with implicitly added includes in Thanks |
In CudaMath.h header file colorSums() uses float3 as input and it is implemented in helper_math.h. The header CudaMath.h do not include helper_math.h in source. But it is included in the main source dxtc.cu file. |
Ok, this is an |
There are multiple cuda-samples requires inclusion of those helper_* files. Below are few examples which I found while debugging requires including helper_* headers. I believe there are many more files which require those inclusions, and it is better we implement the generic solution as we might encounter these issues regularly. |
e863e80
to
a805bfb
Compare
Regenerated the hipify-perl and docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
cuda-samples/* requires helper header files.
Fixes SWDEV-490433