Skip to content

[HeterogeneousDwarf] Support translation of DIOp-based DIExpressions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

epilk
Copy link
Contributor

@epilk epilk commented Mar 18, 2025

These expressions exist downstream on amd-staging and are necessary for
debugging on device. Fixes SWDEV-445691.

Fixed by AMD-Lightning-Internal/llvm-project #1229
These expressions exist downstream on amd-staging and are necessary for
debugging on device. Fixes SWDEV-445691.
@epilk epilk force-pushed the amd/dev/epilking/diop-support branch from afb36e5 to 370168f Compare March 18, 2025 19:11
Copy link

@slinder1 slinder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a moment to get up-to-speed on the SPIRV representation, so I may have missed something, but aside from a few nits this LGTM!

Copy link

@slinder1 slinder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the default is to just link to the GV and not look for the GVE, but I suppose we only really care about the NewElements case anyway for working symbolic debug info, so this LGTM!

(Maybe I answered my question there, and the point is to actively avoid using faulty expressions for the non-heterogeneous case?)

@epilk epilk merged commit bbc750e into ROCm:amd-develop Mar 24, 2025
@AlexVlx
Copy link
Contributor

AlexVlx commented Mar 26, 2025

@epilk something I had not considered, but is important, is that this breaks compatibility with upstream AFAICT (for example the DIExprOps header is not available), and we would like the fork to still build with upstream. Perhaps a __has_include guard would suffice here (and then based on that predicate we can also turn off the unsupported bits).

@epilk
Copy link
Contributor Author

epilk commented Mar 26, 2025

@epilk something I had not considered, but is important, is that this breaks compatibility with upstream AFAICT (for example the DIExprOps header is not available), and we would like the fork to still build with upstream. Perhaps a __has_include guard would suffice here (and then based on that predicate we can also turn off the unsupported bits).

Ah, okay I didn't realize that the downstream translator would need to work with upstream llvm. Using __has_include seems like a good fix, I'll write that up...

@AlexVlx
Copy link
Contributor

AlexVlx commented Mar 26, 2025

@epilk something I had not considered, but is important, is that this breaks compatibility with upstream AFAICT (for example the DIExprOps header is not available), and we would like the fork to still build with upstream. Perhaps a __has_include guard would suffice here (and then based on that predicate we can also turn off the unsupported bits).

Ah, okay I didn't realize that the downstream translator would need to work with upstream llvm. Using __has_include seems like a good fix, I'll write that up...

Thank you and apologies for the inconvenience. I spaced out on this when I reviewed.

@epilk
Copy link
Contributor Author

epilk commented Mar 26, 2025

Thank you and apologies for the inconvenience. I spaced out on this when I reviewed.

No problem, thanks for spotting the issue! #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants