Point hipconfig's ROCM_PATH towards dev packages if develop packages are installed by darren-amd · Pull Request #2870 · ROCm/TheRock

darren-amd · 2026-01-12T20:18:58Z

PR based on #2428.

Motivation

We'd like hipconfig --rocmpath to point towards _rocm_sdk_devel if the rocm[devel] packages are installed. This is useful for code that depends on hipconfig --rocmpath to resolve paths for ROCm files. Aimed as a fix for #1880 and other PyTorch issues that require the develop packages.

Technical Details

The PR at Redirect base exec path for Python CLI scripts if rocm[devel] is installed #2428 successfully directed hipconfig --rocmpath towards the _rocm_sdk_devel packages on Windows but was running into some issues on Linux as we were still using symlinks.
Added a change so Linux also uses hardlinks to avoid this issue.

Test Plan

Linux:

The unit test testCLIUsesDevelRootPath passes (rocm-sdk test passes)
Tested by installing without the devel packages and with the devel packages

pip install --index-url https://rocm.devreleases.amd.com/v2-staging/gfx1151/ "rocm[libraries]==7.11.0.dev0+5d4dfe88517275760144e58af2e70af3dff5d2bc"
hipconfig --rocmpath
# /home/rocm/darren/hipconfig-test/.venv/lib/python3.12/site-packages/_rocm_sdk_core
pip install --index-url https://rocm.devreleases.amd.com/v2-staging/gfx1151/ "rocm[libraries,devel]==7.11.0.dev0+5d4dfe88517275760144e58af2e70af3dff5d2bc"
hipconfig --rocmpath
# /home/rocm/darren/hipconfig-test/.venv/lib/python3.12/site-packages/_rocm_sdk_devel

Test Result

On Linux, the unit test passes and without the develop packages hipconfig --rocmpath correctly points at the core packages. When the develop packages are installed, it correctly expands and points tot he develop packages.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

darren-amd · 2026-01-12T21:12:05Z

Have not tested on Windows yet, will do so after build completes.

marbre · 2026-01-13T17:53:52Z

We had an issue with a history rewrite which confused the GH UI and the commits it is showing on your PR. Please make sure to update your branch e.g. in the GH UI via

Afterwards you need update your local branch via git pull.

Alternative git rebase solution

Alternatively you can manually update your branch locally by following the below instructions:

git checkout <yourbranch>
git fetch origin main
git rebase origin/main
git push --force-with-lease origin <yourbranch>

darren-amd · 2026-01-13T19:15:12Z

Thanks, just verified with build 7.11.0.dev0+5d4dfe88517275760144e58af2e70af3dff5d2bc that tests pass on windows as well.

ScottTodd · 2026-01-14T18:33:11Z

-                        if _is_windows() and ti.issym():
-                            # Convert symlinks into hardlinks on Windows.
-                            # This saves disk space while improving compatibility
-                            # on systems without as robust symlink support.
+                        if ti.issym():
+                            # Convert file symlinks into hardlinks on all platforms.
+                            # This saves disk space while improving compatibility.
+                            # On Windows: symlinks require admin privileges.
+                            # On Linux: native binaries that use readlink(/proc/self/exe)
+                            #   to determine their location will resolve symlinks and
+                            #   report the wrong path (e.g., _rocm_sdk_core instead of
+                            #   _rocm_sdk_devel). Hardlinks avoid this issue.


Thanks, this change looks good to me by I would also like to hear @stellaraccident 's opinion. I was on the fence about making it and discussed a bit with @marbre before and the comment helps justify it, at least to me.

We should probably also update the documentation at https://github.com/ROCm/TheRock/blob/main/docs/packaging/python_packaging.md, specifically this section:

Devel package: The rocm-sdk-devel package is the catch-all for everything.
For any file already populated in a runtime package, it will include it as
a relative symlink (also rewriting shared library soname links as needed).
Since symlinks and non-standard attributes cannot be included in a wheel file,
the platform contents are stored in a _devel.tar or _devel.tar.xz file.
The installed package is extended in response to requesting a path to it
via the rocm-sdk tool.

Thanks Scott, I will update the docs

ScottTodd

LGTM, but I'm a bit worried this may have some unintended side effects on Linux. We have been using hardlinks on Windows though, so 🤷

…stalled (#2428) Fixes #1880. Many projects (such as llama.cpp) look up paths to ROCm files using `hipconfig --rocmpath`. Previously, our CLI scripts would always trampoline to e.g. `_rocm_sdk_core/bin/hipconfig`, even if the development files were available in `_rocm_sdk_devel` (which is a superset of `_rocm_sdk_core`). This trampolines to `_rocm_sdk_devel` if the devel package is installed. * Added a new unit test * Ran various local tests like: ```bash py -V:3.12 -m venv 3.12.venv && .\3.12.venv\Scripts\activate.bat pip install --index-url https://rocm.nightlies.amd.com/v2/gfx110X-all/ --pre rocm[libraries] hipconfig --rocmpath # D:\scratch\therock\3.12.venv\Lib\site-packages\_rocm_sdk_core pip install --index-url https://rocm.nightlies.amd.com/v2/gfx110X-all/ --pre rocm[libraries,devel] hipconfig --rocmpath (Initialized automatically) hipconfig --rocmpath shows no redundant init) ``` - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Makes Linux use hardlinks like Windows does. Fixes hipconfig binary path detection.

…ausing issues)

…inking

stellaraccident

I'm good with this. We probably should have done this from the get-go as symlink indirection can cause many problems.

github-project-automation Bot added this to TheRock Triage Jan 12, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Jan 12, 2026

subodh-dubey-amd force-pushed the main branch from 7e9ba03 to 3077ce8 Compare January 13, 2026 12:08

darren-amd force-pushed the darren-amd/fix-hipconfig-link branch from 5d4dfe8 to 3aad9ba Compare January 13, 2026 19:14

darren-amd marked this pull request as ready for review January 13, 2026 21:43

darren-amd requested a review from ScottTodd January 13, 2026 21:44

ScottTodd reviewed Jan 14, 2026

View reviewed changes

ScottTodd requested a review from stellaraccident January 14, 2026 18:33

ScottTodd approved these changes Jan 14, 2026

View reviewed changes

darren-amd mentioned this pull request Jan 21, 2026

[issue] pytorch linux errors building extension 'dummy_allocator', fatal error: 'hipblas/hipblas.h' file not found #2152

Closed

harkgill-amd requested a review from marbre February 3, 2026 17:47

HereThereBeDragons reviewed Feb 25, 2026

View reviewed changes

amd-aakash requested a review from WBobby February 25, 2026 16:14

ScottTodd and others added 4 commits February 25, 2026 15:37

Use hardlinks instead of symlinks on Linux

189ae6b

Makes Linux use hardlinks like Windows does. Fixes hipconfig binary path detection.

Change to only convert file symlinks to hardlinks (directories were c…

445a203

…ausing issues)

Update python packaging documentation to reflect changes to sym/hardl…

e2907e7

…inking

darren-amd force-pushed the darren-amd/fix-hipconfig-link branch from c68a677 to e2907e7 Compare February 25, 2026 20:40

darren-amd requested a review from HereThereBeDragons February 26, 2026 16:14

stellaraccident approved these changes Mar 4, 2026

View reviewed changes

darren-amd merged commit bf4e415 into main Mar 4, 2026
217 of 228 checks passed

darren-amd deleted the darren-amd/fix-hipconfig-link branch March 4, 2026 22:09

github-project-automation Bot moved this from TODO to Done in TheRock Triage Mar 4, 2026

darren-amd mentioned this pull request Mar 6, 2026

[Issue]: Running hipconfig --rocmpath from Python packages uses 'core' instead of 'devel' and does not include HIP runtime CMake files #1880

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Point hipconfig's ROCM_PATH towards dev packages if develop packages are installed#2870

Point hipconfig's ROCM_PATH towards dev packages if develop packages are installed#2870
darren-amd merged 4 commits intomainfrom
darren-amd/fix-hipconfig-link

darren-amd commented Jan 12, 2026 •

edited

Loading

Uh oh!

darren-amd commented Jan 12, 2026

Uh oh!

marbre commented Jan 13, 2026

Uh oh!

darren-amd commented Jan 13, 2026

Uh oh!

ScottTodd Jan 14, 2026

Uh oh!

darren-amd Jan 14, 2026

Uh oh!

ScottTodd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stellaraccident left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

darren-amd commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

darren-amd commented Jan 12, 2026

Uh oh!

marbre commented Jan 13, 2026

Uh oh!

darren-amd commented Jan 13, 2026

Uh oh!

ScottTodd Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

darren-amd Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

ScottTodd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stellaraccident left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

darren-amd commented Jan 12, 2026 •

edited

Loading