Media Libraries - Python package by kiritigowda · Pull Request #3579 · ROCm/TheRock

kiritigowda · 2026-02-24T07:38:44Z

Motivation

Python packaging for media libraries (rocdecode & rocjpeg)

Technical Details

Libs are being included in rocm-sdk-core (via core_artifact_filter + _dist_info.py LibraryEntry)

Test Plan

Verify if media packages are generated

Test Result

No current tests should fail

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

marbre

I'd suggest to split this up to land native packages and Python packages separately. While the PR title suggests this only adds Python packages, it also adds native Linux packages.

Python packages are failing: https://github.com/ROCm/TheRock/actions/runs/22341297194/job/64655355988?pr=3579

We should also discuss the gating. Other components can also be disabled in the build system but aren't have these kind of checks. I think it could either go into the packages with appropriate defaults set (which makes gating superfluous) or we may want to create a separate package?

kiritigowda · 2026-02-24T23:34:19Z

I'd suggest to split this up to land native packages and Python packages separately. While the PR title suggests this only adds Python packages, it also adds native Linux packages.

Python packages are failing: https://github.com/ROCm/TheRock/actions/runs/22341297194/job/64655355988?pr=3579

We should also discuss the gating. Other components can also be disabled in the build system but aren't have these kind of checks. I think it could either go into the packages with appropriate defaults set (which makes gating superfluous) or we may want to create a separate package?

@marbre - Updated to reflect the linux and python package additions. The naming and being part of the core was provided by packaging requirements. I have removed the extra checks to match existing method all packages follow.

marbre · 2026-02-25T00:20:32Z

I'd suggest to split this up to land native packages and Python packages separately. While the PR title suggests this only adds Python packages, it also adds native Linux packages.
Python packages are failing: https://github.com/ROCm/TheRock/actions/runs/22341297194/job/64655355988?pr=3579
We should also discuss the gating. Other components can also be disabled in the build system but aren't have these kind of checks. I think it could either go into the packages with appropriate defaults set (which makes gating superfluous) or we may want to create a separate package?

@marbre - Updated to reflect the linux and python package additions. The naming and being part of the core was provided by packaging requirements. I have removed the extra checks to match existing method all packages follow.

@kiritigowda with the above I was referring to add an additional Python package eventually. The extra checks also only affected Python packages and were unrelated to native Linux packages. Please also update the PR description. Splitting might still be the easier path forward as different folks need to review the different parts (the reviewers you originally requested were not involved in Python packaging).

Edit: I think we may want to handle this similar like other tools? See 505df93.

nunnikri

packaging/linux/package.json changes LGTM

kiritigowda · 2026-02-25T19:11:02Z

packaging/linux/package.json changes LGTM

@nunnikri can you review the PR #3614, I moved the changes to a new pr to separate linux and python

kiritigowda · 2026-02-25T19:16:57Z

@marbre -- RFC doesnt talk abt amdrocm-media meta package. So rocdecode and rocjpeg just needs to be part of rocm-core-sdk. https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0009-OS-Packaging-Requirements.md, if there are any other plans for a new package let us know @stellaraccident

marbre · 2026-02-25T21:25:11Z

@marbre -- RFC doesnt talk abt amdrocm-media meta package. So rocdecode and rocjpeg just needs to be part of rocm-core-sdk. https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0009-OS-Packaging-Requirements.md, if there are any other plans for a new package let us know @stellaraccident

The RFC only refers to native Linux packages and says

Out of Scope

Python pip and wheelnext packaging requirements

@kiritigowda, see my previous comment

with the above I was referring to add an additional Python package eventually

I explicitly raised if we should add a new Python package, this is not covered by the RFC.

kiritigowda · 2026-02-25T21:46:59Z

@marbre -- RFC doesnt talk abt amdrocm-media meta package. So rocdecode and rocjpeg just needs to be part of rocm-core-sdk. https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0009-OS-Packaging-Requirements.md, if there are any other plans for a new package let us know @stellaraccident

The RFC only refers to native Linux packages and says

Out of Scope

Python pip and wheelnext packaging requirements

@kiritigowda, see my previous comment

with the above I was referring to add an additional Python package eventually

I explicitly raised if we should add a new Python package, this is not covered by the RFC.

@marbre I did create amdrocm-media python package in the original media addition PR, but was asked not to create a new package in the review - #3098 (comment)

We are open to creating a new/add to existing, I don't have an issue with either. In this PR we are trying to be consistent with the linux package

erman-gurses

A couple of suggestions from my side as far as I understand:

Please update the PR description to reflect current scope (Python-only; Linux moved to #3614) and explicitly state that these libs are being included in rocm-sdk-core (via core_artifact_filter + _dist_info.py LibraryEntry).
Strengthen the test plan with concrete verification steps (e.g., inspect the built rocm-sdk-core wheel contents and confirm librocdecode.so* / librocjpeg.so* are present in expected paths).

Linux packaging updates in PR #3614

marbre · 2026-02-26T00:03:41Z

@marbre -- RFC doesnt talk abt amdrocm-media meta package. So rocdecode and rocjpeg just needs to be part of rocm-core-sdk. https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0009-OS-Packaging-Requirements.md, if there are any other plans for a new package let us know @stellaraccident

The RFC only refers to native Linux packages and says

Out of Scope

Python pip and wheelnext packaging requirements

@kiritigowda, see my previous comment

with the above I was referring to add an additional Python package eventually

I explicitly raised if we should add a new Python package, this is not covered by the RFC.

@marbre I did create amdrocm-media python package in the original media addition PR, but was asked not to create a new package in the review - #3098 (comment)

You're mixing up things. The RFC as well as the comment you're linking to is for native Linux packages. My question is about Python packages.

We are open to creating a new/add to existing, I don't have an issue with either. In this PR we are trying to be consistent with the linux package

Python packages and native Linux packages are not consistent anyway as we for now only have rocm, rocm-sdk-core, rocm-sdk-devel and rocm-sdk-libraries-{gpu-family}. With the optional guards you introduced initially to include meda-libs only if present in the build, it seemed reasonable to me to ask the question if one should rather create a separate Python package. If media-libs is always on in the default build it can also go to the existing package structure. Anyway, the question came up as you made this kind of optional in the beginning so I think it is fair to discuss.

## Motivation Split PR #3579 into linux and python -- This PR contains linux packaging implementation ## Technical Details Media linux packages ## Test Plan Current tests ## Test Result No current tests should fail ## Submission Checklist - [x ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

kiritigowda · 2026-02-26T05:08:41Z

@marbre -- RFC doesnt talk abt amdrocm-media meta package. So rocdecode and rocjpeg just needs to be part of rocm-core-sdk. https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0009-OS-Packaging-Requirements.md, if there are any other plans for a new package let us know @stellaraccident

The RFC only refers to native Linux packages and says

Out of Scope

Python pip and wheelnext packaging requirements

@kiritigowda, see my previous comment

with the above I was referring to add an additional Python package eventually

I explicitly raised if we should add a new Python package, this is not covered by the RFC.

@marbre I did create amdrocm-media python package in the original media addition PR, but was asked not to create a new package in the review - #3098 (comment)

You're mixing up things. The RFC as well as the comment you're linking to is for native Linux packages. My question is about Python packages.

We are open to creating a new/add to existing, I don't have an issue with either. In this PR we are trying to be consistent with the linux package

Python packages and native Linux packages are not consistent anyway as we for now only have rocm, rocm-sdk-core, rocm-sdk-devel and rocm-sdk-libraries-{gpu-family}. With the optional guards you introduced initially to include meda-libs only if present in the build, it seemed reasonable to me to ask the question if one should rather create a separate Python package. If media-libs is always on in the default build it can also go to the existing package structure. Anyway, the question came up as you made this kind of optional in the beginning so I think it is fair to discuss.

@marbre I agree with you, the core libraries can not be optional. We need to have a discussion and figure this out. Let me know if you have any directions or discuss this in the office hours?

HereThereBeDragons

this pr still seems to mix with #3098 where you now decided to introduce a new python packages rocm-media? was there already some discussion?

maybe you can also explain more why media libs should be an optional requirement - compared to the other components we are having.

please also update your pr description with more context - as this should be also a helpful message for people not familiar with media libs. e.g. it would be good to also reference the other pr for native packaging (and match titles) and the pr where the media libs were introduced.

and some testing will be needed to verify that the python wheels include correctly the media libs and they can be used.

please untangle this pr and #3098 so that one can better review those prs.

edit: fixed link to correct pr

kiritigowda · 2026-02-26T22:05:50Z

A couple of suggestions from my side as far as I understand:

Please update the PR description to reflect current scope (Python-only; Linux moved to Media - linux package #3614) and explicitly state that these libs are being included in rocm-sdk-core (via core_artifact_filter + _dist_info.py LibraryEntry).

Strengthen the test plan with concrete verification steps (e.g., inspect the built rocm-sdk-core wheel contents and confirm librocdecode.so* / librocjpeg.so* are present in expected paths).

@erman-gurses -- added the comments to the description. The tests to verify the install is a good step, we can add that as an enhancement. (There is no current framework to test any libs in python package in the CI)

kiritigowda · 2026-02-26T22:16:29Z

this pr still seems to mix with #3098 where you now decided to introduce a new python packages rocm-media? was there already some discussion?

maybe you can also explain more why media libs should be an optional requirement - compared to the other components we are having.

please also update your pr description with more context - as this should be also a helpful message for people not familiar with media libs. e.g. it would be good to also reference the other pr for native packaging (and match titles) and the pr where the media libs were introduced.

and some testing will be needed to verify that the python wheels include correctly the media libs and they can be used.

please untangle this pr and #3098 so that one can better review those prs.

edit: fixed link to correct pr

@HereThereBeDragons The PR #3098 was the original PR with the full integration of media libraries, we took the reviewer comment and split this PR into multiple PRs. Currently this PR #3098 only has test inclusion.

@marbre - For python packaging on the rock, the media libraries are always built by design, it's only optional for end-user. The media libraries (rocdecode and rocjpeg) are being added to the core sdk to match the linux packaging.

For now we want this to be included as core sdk.

HereThereBeDragons

@kiritigowda from your discussion i still dont understand the final decision:

put media into a separate python packages (which the other pr does)
or like this PR: have it in rocm-core

if it is in rocm-core you cannot have it as a conditional logic that it isnt always added to the package.

if you are unsure which is the best approach, then please bring up the topic during the office hours or maybe @saadrahim has some preference?

kiritigowda · 2026-02-27T19:16:42Z

@kiritigowda from your discussion i still dont understand the final decision:

put media into a separate python packages (which the other pr does)

or like this PR: have it in rocm-core

if it is in rocm-core you cannot have it as a conditional logic that it isnt always added to the package.

if you are unsure which is the best approach, then please bring up the topic during the office hours or maybe @saadrahim has some preference?

@HereThereBeDragons - the media libs are included in core sdk for linux - In this PR we are being consistent.

Media - Python packages

2e4f781

kiritigowda requested review from AryanSalmanpour, nunnikri and raramakr February 24, 2026 07:38

kiritigowda self-assigned this Feb 24, 2026

kiritigowda added the enhancement New feature or request label Feb 24, 2026

Merge branch 'main' into kg/media-package

e829b62

marbre reviewed Feb 24, 2026

View reviewed changes

kiritigowda and others added 5 commits February 24, 2026 09:39

Merge branch 'main' into kg/media-package

3d4c9b2

Format - Fix

1318661

Python Package - Remove lib test

05017a8

Linux - Package updates

199a636

Merge branch 'main' into kg/media-package

539505c

kiritigowda changed the title ~~Media - Python packages~~ Media - Packages (Linux & Python) Feb 24, 2026

nunnikri previously approved these changes Feb 25, 2026

View reviewed changes

erman-gurses requested a review from marbre February 25, 2026 16:09

HereThereBeDragons self-requested a review February 25, 2026 17:17

Merge branch 'main' into kg/media-package

9faac69

kiritigowda mentioned this pull request Feb 25, 2026

Media - linux package #3614

Merged

Linux - packaging removed

f5da2ff

kiritigowda changed the title ~~Media - Packages (Linux & Python)~~ Media - Python Packages Feb 25, 2026

kiritigowda changed the title ~~Media - Python Packages~~ Media - Python package Feb 25, 2026

erman-gurses self-requested a review February 25, 2026 19:11

kiritigowda requested a review from stellaraccident February 25, 2026 19:17

erman-gurses reviewed Feb 25, 2026

View reviewed changes

kiritigowda requested a review from nunnikri February 25, 2026 23:57

Merge branch 'main' into kg/media-package

cfe2977

HereThereBeDragons reviewed Feb 26, 2026

View reviewed changes

Comment thread build_tools/packaging/python/templates/rocm/src/rocm_sdk/_dist_info.py

Merge branch 'main' into kg/media-package

b6449d3

kiritigowda changed the title ~~Media - Python package~~ Media Libraries - Python package Feb 26, 2026

Merge branch 'main' into kg/media-package

5d94e41

kiritigowda requested review from HereThereBeDragons and erman-gurses February 26, 2026 22:16

AryanSalmanpour approved these changes Feb 27, 2026

View reviewed changes

rrawther approved these changes Feb 27, 2026

View reviewed changes

HereThereBeDragons requested changes Feb 27, 2026

View reviewed changes

stellaraccident approved these changes Feb 27, 2026

View reviewed changes

kiritigowda requested a review from HereThereBeDragons February 27, 2026 19:17

HereThereBeDragons approved these changes Feb 27, 2026

View reviewed changes

kiritigowda merged commit e95e2d7 into ROCm:main Feb 27, 2026
88 of 92 checks passed

kiritigowda deleted the kg/media-package branch February 27, 2026 20:11

Conversation

kiritigowda commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

marbre left a comment

Choose a reason for hiding this comment

Uh oh!

kiritigowda commented Feb 24, 2026

Uh oh!

marbre commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nunnikri left a comment

Choose a reason for hiding this comment

Uh oh!

kiritigowda commented Feb 25, 2026

Uh oh!

kiritigowda commented Feb 25, 2026

Uh oh!

marbre commented Feb 25, 2026

Uh oh!

kiritigowda commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erman-gurses left a comment

Choose a reason for hiding this comment

Uh oh!

marbre commented Feb 26, 2026

Uh oh!

kiritigowda commented Feb 26, 2026

Uh oh!

HereThereBeDragons left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kiritigowda commented Feb 26, 2026

Uh oh!

kiritigowda commented Feb 26, 2026

Uh oh!

HereThereBeDragons left a comment

Choose a reason for hiding this comment

Uh oh!

kiritigowda commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kiritigowda commented Feb 24, 2026 •

edited

Loading

marbre commented Feb 25, 2026 •

edited

Loading

kiritigowda commented Feb 25, 2026 •

edited

Loading

HereThereBeDragons left a comment •

edited

Loading