[hipDNN] Include hipdnn test executables that end with singular 'test'#3616
Merged
CMiservaAMD merged 4 commits intomainfrom Mar 2, 2026
Merged
Conversation
CMiservaAMD
changed the title
BrianHarrisonAMD
approved these changes
Feb 25, 2026
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
Heh silly.
I think this can go in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A test executable was added to exercise a specific scenario. The filename ended in "_test" instead of the typical "_tests" and was therefore not being included in the test archive.
Technical Details
Changed test glob patter to end with "_test*" instead of the original "_tests*".
Test Plan
CI tests pass.
Test Result
Submission Checklist