Skip to content

Add unittests for generate_package_indexes_test.py script#3623

Merged
erman-gurses merged 1 commit intomainfrom
users/erman-gurses/add-unittests-for-generate_package_indexes
Mar 2, 2026
Merged

Add unittests for generate_package_indexes_test.py script#3623
erman-gurses merged 1 commit intomainfrom
users/erman-gurses/add-unittests-for-generate_package_indexes

Conversation

@erman-gurses
Copy link
Copy Markdown
Contributor

@erman-gurses erman-gurses commented Feb 25, 2026

Closes #3328
Follow up PR for #3566
Add unittests for generate_package_indexes_test.py script

pytest build_tools/packaging/tests/generate_package_indexes_test.py -vv
=================================================================================== test session starts ===================================================================================
platform linux -- Python 3.12.12, pytest-8.4.2, pluggy-1.6.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/nod/ergurses/TheRock/build_tools
configfile: pyproject.toml
collected 4 items                                                                                                                                                                         

build_tools/packaging/tests/generate_package_indexes_test.py::GeneratePackageIndexesTest::test_generate_index_from_s3_creates_indexes_and_links PASSED                              [ 25%]
build_tools/packaging/tests/generate_package_indexes_test.py::GeneratePackageIndexesTest::test_generate_index_from_s3_respects_max_depth PASSED                                     [ 50%]
build_tools/packaging/tests/generate_package_indexes_test.py::GeneratePackageIndexesTest::test_generate_index_html_skips_dotfiles PASSED                                            [ 75%]
build_tools/packaging/tests/generate_package_indexes_test.py::GeneratePackageIndexesTest::test_generate_top_index_from_s3_lists_subfolders PASSED                                   [100%]

==================================================================================== 4 passed in 0.11s ====================================================================================

@marbre
Copy link
Copy Markdown
Member

marbre commented Feb 25, 2026

@HereThereBeDragons or @araravik-psd please review if the unit tests are meaning full. This won't need a review from me.

@marbre marbre removed their request for review February 25, 2026 23:55
@erman-gurses
Copy link
Copy Markdown
Contributor Author

@HereThereBeDragons @araravik-psd can you please give a review for that.

Copy link
Copy Markdown
Contributor

@araravik-psd araravik-psd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage and tests LGTM!

@erman-gurses erman-gurses merged commit 5a77600 into main Mar 2, 2026
109 of 116 checks passed
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Mar 2, 2026
@erman-gurses erman-gurses deleted the users/erman-gurses/add-unittests-for-generate_package_indexes branch March 2, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Split index.html generation from upload_package_repo.py

3 participants