Skip to content

SMP bump for 5 additional CPs#4316

Closed
ronlieb wants to merge 1 commit intomainfrom
amd/dev/rlieberm/ww11postPRs-1
Closed

SMP bump for 5 additional CPs#4316
ronlieb wants to merge 1 commit intomainfrom
amd/dev/rlieberm/ww11postPRs-1

Conversation

@ronlieb
Copy link
Copy Markdown
Contributor

@ronlieb ronlieb commented Apr 2, 2026

Conditional GO from CQE : LenineA

Fixes kokoos cmake 3.29.3 issue:
e377b44 [ClangLinkerWrapper] Fix -v for newer C Make passing it directly (llvm#188883)

one PR needed from previous ww06 branch:
50ce47b Revert [IndVarsSimplify] sinkUnusedInvariants is skipping instruction… (#804)

3 gfx1250 PRs:
7602fbe [AMDGPU] Set gfx1250 default to B0
1cdcbfb [AMDGPU] Change A0/B0 commentary to only affect gfx1250 (#1790)
dc69bc9 [gpurun] add backfill for empty gpu_affinity (#1943)

e377b44 [ClangLinkerWrapper] Fix -v for newer C Make passing it directly (llvm#188883)
50ce47b Revert [IndVarsSimplify] sinkUnusedInvariants is skipping instruction… (#804)
7602fbe [AMDGPU] Set gfx1250 default to B0
1cdcbfb [AMDGPU] Change A0/B0 commentary to only affect gfx1250 (#1790)
dc69bc9 [gpurun] add backfill for empty gpu_affinity (#1943)
Copy link
Copy Markdown
Contributor

@searlmc1 searlmc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@searlmc1 searlmc1 changed the title SMP bump for 5 addional CPs SMP bump for 5 additional CPs Apr 2, 2026
@lajagapp
Copy link
Copy Markdown
Contributor

lajagapp commented Apr 3, 2026

Daily level staging testing is completed, no new issues on staging testing.

From PR check, two tests failure observed.
hip-tests failure (Unit_NonHost_Printf_BufferAvailability) - we have PR already to disable this test temporarily - #4245
rocprofiler-compute failure (test_profile_pc_sampling) - I see same test failed in yesterday's Nightly-CI run - https://github.com/ROCm/TheRock/actions/runs/23881683179/job/69646100279

@ronlieb
Copy link
Copy Markdown
Contributor Author

ronlieb commented Apr 3, 2026

Daily level staging testing is completed, no new issues on staging testing.

From PR check, two tests failure observed. hip-tests failure (Unit_NonHost_Printf_BufferAvailability) - we have PR already to disable this test temporarily - #4245 rocprofiler-compute failure (test_profile_pc_sampling) - I see same test failed in yesterday's Nightly-CI run - https://github.com/ROCm/TheRock/actions/runs/23881683179/job/69646100279

we are FIRST going to land the PR #4331 that changes default for HIP driver to be old driver, this will resolve the hip-tests issue, and likely the rocprofiler issue, in addition to the rocgdb issue. Then we can rebase this PR on top of hip-driver change. so i dont think we will need to xfail the test temporarily.

ronlieb added a commit that referenced this pull request Apr 4, 2026
…13 : ww11

rebase on top of old hip driver, conditional go provided for earlier version of this
#4316

c90f6c1192b7 [ClangLinkerWrapper] Fix `-v` for newer CMake passing it directly (#188883)
5ab609653937 Revert [IndVarsSimplify] sinkUnusedInvariants is skipping instruction… (#804)
4e9ad818ed41 [AMDGPU] Set gfx1250 default to B0
350422532acb [AMDGPU] Change A0/B0 commentary to only affect gfx1250 (#1790)
b4717834dd37 [gpurun] add backfill for empty gpu_affinity (#1943)
A
@ronlieb
Copy link
Copy Markdown
Contributor Author

ronlieb commented Apr 4, 2026

reworked PR on top of HIP driver PR : #4346

@ronlieb ronlieb closed this Apr 4, 2026
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Apr 4, 2026
ronlieb added a commit that referenced this pull request Apr 5, 2026
…13 : ww11

rebase on top of old hip driver, conditional go provided for earlier version of this
#4316

c90f6c1192b7 [ClangLinkerWrapper] Fix `-v` for newer CMake passing it directly (#188883)
5ab609653937 Revert [IndVarsSimplify] sinkUnusedInvariants is skipping instruction… (#804)
4e9ad818ed41 [AMDGPU] Set gfx1250 default to B0
350422532acb [AMDGPU] Change A0/B0 commentary to only affect gfx1250 (#1790)
b4717834dd37 [gpurun] add backfill for empty gpu_affinity (#1943)
A
rahulc-gh pushed a commit that referenced this pull request Apr 9, 2026
…13 : ww11

rebase on top of old hip driver, conditional go provided for earlier version of this
#4316

c90f6c1192b7 [ClangLinkerWrapper] Fix `-v` for newer CMake passing it directly (#188883)
5ab609653937 Revert [IndVarsSimplify] sinkUnusedInvariants is skipping instruction… (#804)
4e9ad818ed41 [AMDGPU] Set gfx1250 default to B0
350422532acb [AMDGPU] Change A0/B0 commentary to only affect gfx1250 (#1790)
b4717834dd37 [gpurun] add backfill for empty gpu_affinity (#1943)
A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants