Windows reproducible build & ccache hit rate improvement#4419
Open
amd-nicknick wants to merge 4 commits intomainfrom
Open
Windows reproducible build & ccache hit rate improvement#4419amd-nicknick wants to merge 4 commits intomainfrom
amd-nicknick wants to merge 4 commits intomainfrom
Conversation
5 tasks
f2d6892 to
1b5b39e
Compare
4 tasks
1b5b39e to
6bb28ad
Compare
6bb28ad to
f5c4f87
Compare
astrelsky
reviewed
Apr 18, 2026
b111e5b to
3e7e2b0
Compare
3e7e2b0 to
f57b671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4519, parent issue #4195
Technical Details
/Breprofor MSVC toolchainEnsure amd-llvm is reproducible & COFF header contains a reproducible hash instead of current timestamp.
compiler_check=contentfor WindowsSwitch
compiler_checkfrommtimetocontent. Since the LLVM toolchain on Windows is statically linked, hashing the compiler binary content is sufficient and more reliable for detecting actual compiler changes across CI runs.Add
pch_definesandtime_microsto ccache sloppiness. amd-llvm on Windows builds uses precompiled headers by default.Max size bump to 10G, rename
secondary_storagetoremote_storageTest Plan
Validate cache hitrate on Windows following subsequent buil.ds
Test Result
Submission Checklist