[test-only] Deprecate HIPCC#5081
Draft
david-salinas wants to merge 6 commits intomainfrom
Draft
Conversation
Add CMAKE_HIP_COMPILER and --rtlib/--unwindlib linker flags to the amd-hip toolchain so all subprojects get the correct HIP compiler without needing hipcc as a wrapper. - cmake/therock_subproject.cmake: set CMAKE_HIP_COMPILER to the built clang++ and add --rtlib=compiler-rt --unwindlib=libgcc to linker flags - core/CMakeLists.txt: remove hipcc from hip-clr RUNTIME_DEPS - math-libs/CMakeLists.txt: remove hipcc from libhipcxx COMPILER_TOOLCHAIN and RUNTIME_DEPS - Rename test_libhipcxx_hipcc.py -> test_libhipcxx_amdclang.py and update it to invoke amdclang++ directly Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Updates the amd-llvm submodule to include a deprecation warning emitted to stderr when hipcc is invoked with --help or -h. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Documents the deprecation of hipcc in favor of calling amdclang++ directly, covering: why the change is being made, what changed in TheRock's amd-hip toolchain, a flag equivalency table mapping hipcc's implicit behavior to explicit amdclang++ flags, and migration guidance for CMake projects, Makefile/shell-based projects, and callers of hipconfig introspection. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
This reverts commit a6bb7cb.
…tems Add two patches carrying our hipcc deprecation changes as TheRock patch files so they can be applied via fetch_sources.py to the submodules: - patches/amd-mainline/llvm-project/: hipcc deprecation warning on --help/-h (compiler/amd-llvm branch users/dsalinas/deprecate-hipcc) - patches/amd-mainline/rocm-systems/: hip-tests drop hipconfig find_program/execute_process, derive HIP version from find_package(hip) Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Add a second patch for rocm-systems carrying the roctracer test migration from legacy find_package(HIP MODULE) to enable_language(HIP). The legacy FindHIP.cmake module (CMake 3.27 built-in) requires HIP_HIPCC_EXECUTABLE and HIP_HIPCONFIG_EXECUTABLE, which are no longer available in the dist after hipcc was removed from hip-clr's RUNTIME_DEPS. Also regenerates the existing hip-tests patch (0001) as part of the format-patch run — content is unchanged. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist