Skip to content

Enhance Install Test - add multi arch install, versioned pkg install options.#5086

Draft
arvindcheru wants to merge 4 commits intomainfrom
users/acheruva/enable_multiarch_install_test_apr17
Draft

Enhance Install Test - add multi arch install, versioned pkg install options.#5086
arvindcheru wants to merge 4 commits intomainfrom
users/acheruva/enable_multiarch_install_test_apr17

Conversation

@arvindcheru
Copy link
Copy Markdown
Contributor

Motivation

This pull request significantly refactors and extends the flexibility of the native Linux ROCm package installation test script. The main improvements are centered around supporting versioned and generic package naming, more robust handling of GPU architecture arguments, and improved environment and CLI integration. The changes also update documentation, error handling, and test cases to match the new logic.

Technical Details

Flexible ROCm Package Naming and Architecture Handling

  • Added support for versioned package names (amdrocm7.13, amdrocm-core-sdk7.13) and architecture-specific variants (e.g., amdrocm7.13-gfx1100) via a new --rocm-version argument and corresponding environment variable. The logic now distinguishes between generic, versioned, and arch-specific package names depending on the combination of --gfx-arch and --rocm-version inputs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

  • Improved normalization and validation of the --gfx-arch argument, now allowing for multiple architectures, comma-separated lists, and ensuring correct lowercasing and deduplication. If omitted, generic packages are installed. [1] [2] [3]

CLI, Environment, and Error Handling

  • Updated CLI argument parsing to support the new --rocm-version flag and improved help text for --gfx-arch. The script now also parses and validates ROCm version strings for correctness. [1] [2]

  • Enhanced environment variable integration: the workflow now uses NATIVE_LINUX_INSTALL_ROCM_VERSION to set versioned package names, and GFX_ARCH is now optional. The script builds CLI arguments accordingly. [1] [2] [3] [4] [5]

Miscellaneous

  • Minor improvements to the RDHC test runner arguments and Python installation logic in the setup script, ensuring better compatibility and correctness across distributions. [1] [2] [3]

These changes provide greater flexibility for CI and ad-hoc testing, allow for more precise package selection, and improve maintainability and clarity of the test infrastructure.

Test Plan

  • Updated unit tests to reflect new default behavior: omitting gfx_arch now results in generic package names rather than defaulting to a specific architecture.

Test Result

Submission Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant