Enhance Install Test - add multi arch install, versioned pkg install options.#5086
Draft
arvindcheru wants to merge 4 commits intomainfrom
Draft
Enhance Install Test - add multi arch install, versioned pkg install options.#5086arvindcheru wants to merge 4 commits intomainfrom
arvindcheru wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request significantly refactors and extends the flexibility of the native Linux ROCm package installation test script. The main improvements are centered around supporting versioned and generic package naming, more robust handling of GPU architecture arguments, and improved environment and CLI integration. The changes also update documentation, error handling, and test cases to match the new logic.
Technical Details
Flexible ROCm Package Naming and Architecture Handling
Added support for versioned package names (
amdrocm7.13,amdrocm-core-sdk7.13) and architecture-specific variants (e.g.,amdrocm7.13-gfx1100) via a new--rocm-versionargument and corresponding environment variable. The logic now distinguishes between generic, versioned, and arch-specific package names depending on the combination of--gfx-archand--rocm-versioninputs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Improved normalization and validation of the
--gfx-archargument, now allowing for multiple architectures, comma-separated lists, and ensuring correct lowercasing and deduplication. If omitted, generic packages are installed. [1] [2] [3]CLI, Environment, and Error Handling
Updated CLI argument parsing to support the new
--rocm-versionflag and improved help text for--gfx-arch. The script now also parses and validates ROCm version strings for correctness. [1] [2]Enhanced environment variable integration: the workflow now uses
NATIVE_LINUX_INSTALL_ROCM_VERSIONto set versioned package names, andGFX_ARCHis now optional. The script builds CLI arguments accordingly. [1] [2] [3] [4] [5]Miscellaneous
These changes provide greater flexibility for CI and ad-hoc testing, allow for more precise package selection, and improve maintainability and clarity of the test infrastructure.
Test Plan
gfx_archnow results in generic package names rather than defaulting to a specific architecture.Test Result
Submission Checklist