Skip to content

[rocSOLVER] Increase test timeout #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tfalders wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

[rocSOLVER] Increase test timeout #5087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions build_tools/github_actions/fetch_test_configurations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,8 @@ def _get_script_path(script_name: str) -> str:
"rocsolver": {
"job_name": "rocsolver",
"fetch_artifact_args": "--blas --tests",
# 68350(approx) tests needs 48 mins, so 48 mins / 2 shards = 24 mins per shard
# 24 mins + 20% margin = 30 mins => ~40 mins (considering gpu delays and lags)
"timeout_minutes": 60,
# Extended tests on math-ci take approx 5 hrs (as of May 5, 2026)
"timeout_minutes": 120,
Copy link
Copy Markdown
Contributor

@geomin12 geomin12 May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's work on test standardization for rocsolver soon! https://github.com/ROCm/TheRock/blob/main/docs/development/test_filtering.md

having a developer wait 360 minutes for tests to run in a PR is not good

perhaps, could we do just standard tests instead of extended? and if nightly, we run extended?

"test_script": f"python {_get_script_path('test_rocsolver.py')}",
# Issue for adding windows tests: https://github.com/ROCm/TheRock/issues/1770
"platform": ["linux"],
Expand Down
Loading