Skip to content

[rocprofiler-compute] Fix RPATH for rocprofiler-compute test binary in non-default install location #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vedithal-amd merged 1 commit into from
May 8, 2026
+13 −0
Merged

[rocprofiler-compute] Fix RPATH for rocprofiler-compute test binary in non-default install location #5108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions profiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ if(THEROCK_ENABLE_ROCPROFILER_COMPUTE)
therock_explicit_finders.cmake
COMPILER_TOOLCHAIN
amd-hip
INSTALL_RPATH_DIRS
"lib/rocprofiler-compute"
RUNTIME_DEPS
rocprofiler-sdk
aqlprofile
Expand Down
11 changes: 11 additions & 0 deletions profiler/post_hook_rocprofiler-compute.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Copyright Advanced Micro Devices, Inc.
# SPDX-License-Identifier: MIT

# test-rocprofiler-compute-tool installs to libexec/rocprofiler-compute/tests/
# instead of the default bin/. Tell TheRock the actual origin so it can compute
# correct relative RPATH entries.
if(TARGET test-rocprofiler-compute-tool)
set_target_properties(test-rocprofiler-compute-tool PROPERTIES
THEROCK_INSTALL_RPATH_ORIGIN libexec/rocprofiler-compute/tests
)
endif()
Comment on lines +4 to +11
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I ran an audit across the project for other targets that might need similar treatment: https://github.com/ScottTodd/claude-rocm-workspace/blob/main/reviews/pr_TheRock_5108.md#broader-analysis-other-targets-that-may-be-affected

potentially missing:

  • roctracer codeobj_test and test executables
  • aqlprofile test executables
  • rocprofiler (v1), though we don't build it in TheRock and probably don't plan to in the future?

I also checked if we could validate RPATH correctness through unit tests to ensure we don't regress here. See https://github.com/ScottTodd/claude-rocm-workspace/blob/main/reviews/pr_TheRock_5108.md#unit-test-coverage-for-rpath-correctness for a ideas there

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #5114 to follow up so we don't regress and other subprojects getting onboarded can have more confidence that the packaging will work

Loading