Adding msgpack and zstandard to requirements-test.txt

[ajanicijamd]

Motivation

Adding missing pip modules.

Technical Details

The cmake --build /therock/output/build step fails because modules msgpack and zstandard are not installed.

Test Plan

• Go through the steps of building TheRock.
• Before executing cmake --build /therock/output/build, run pip install -r /therock/src/requirements-test.txt.
• cmake --build /therock/output/build must succeed.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[ScottTodd]

This shouldn't be needed, unless you can show a test that needs these requirements, along with a specific error message.

Please also title your PRs, instead of using the branch name "Users/ajanicijamd/update requirements test" that github defaults to.

[ScottTodd]

The requirements file for building is https://github.com/ROCm/TheRock/blob/main/requirements.txt, and that already includes these packages.

[ajanicijamd]

Yes, but outside the container. After the step
./build_tools/linux_portable_build.py --interactive
the command is in the container, where the configuration and build are done. And the packages are not there.

[ajanicijamd]

Here's the failure for msgpack:

FAILED: artifacts/rccl_run_generic/artifact_manifest.txt /therock/output/build/artifacts/rccl_run_generic/artifact_manifest.txt
cd /therock/output/build/comm-libs && /usr/local/therock-tools/bin/cmake -E env PYTHONPATH=/therock/src/rocm-systems/shared/kpack/python /opt/python/cp312-cp312/bin/python3.12 /therock/src/rocm-systems/shared/kpack/python/rocm_kpack/tools/split_artifacts.py --artifact-dir /therock/output/build/artifacts-unsplit/rccl_run_generic --output-dir /therock/output/build/artifacts/ --artifact-prefix rccl_run --clang-offload-bundler /therock/output/build/compiler/amd-llvm/dist/lib/llvm/bin/clang-offload-bundler --gpu-targets gfx1100 gfx1101 gfx1102 gfx1103
Traceback (most recent call last):
  File "/therock/src/rocm-systems/shared/kpack/python/rocm_kpack/tools/split_artifacts.py", line 22, in <module>
    from rocm_kpack.artifact_splitter import ArtifactSplitter
  File "/therock/src/rocm-systems/shared/kpack/python/rocm_kpack/artifact_splitter.py", line 18, in <module>
    from rocm_kpack.artifact_utils import (
  File "/therock/src/rocm-systems/shared/kpack/python/rocm_kpack/artifact_utils.py", line 12, in <module>
    from rocm_kpack.binutils import Toolchain
  File "/therock/src/rocm-systems/shared/kpack/python/rocm_kpack/binutils.py", line 9, in <module>
    import msgpack
ModuleNotFoundError: No module named 'msgpack'

[ScottTodd]

linux_portable_build.py is not in active use (on public github here) outside of documentation. It could be deleted.

It should already be installing requirements.txt though, not requirements-test.txt:

TheRock/build_tools/detail/linux_portable_build_in_container.sh

Line 23 in f40a854

pip install -r /therock/src/requirements.txt