Skip to content

Revert "ci(manifest-diff): Post manifest-diff report link as a bump-PR comment" - #7716

Merged
rahulc-gh merged 1 commit into
mainfrom
revert-6754-users/hsivasun/manifest-diff-pr-comment
Aug 28, 2026
Merged

Revert "ci(manifest-diff): Post manifest-diff report link as a bump-PR comment"#7716
rahulc-gh merged 1 commit into
mainfrom
revert-6754-users/hsivasun/manifest-diff-pr-comment

Conversation

@amd-hsivasun

Copy link
Copy Markdown
Contributor

Reverts #6754

@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description is too short (25 characters).
Expected: at least 30 characters.
Current: please provide a meaningful description of your changes
───
Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 28, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@amd-hsivasun

Copy link
Copy Markdown
Contributor Author

This PR was merged without having addressed some comments. The comments did not load until after I merged the PR for some reason.

@ScottTodd

Copy link
Copy Markdown
Member

At least we can see it running with the code that did get merged 😅 #7718 (comment) good to see that it worked without bugs.

@rahulc-gh

Copy link
Copy Markdown
Contributor

Merging revert PR as the comments were not addressed in original PR

@rahulc-gh
rahulc-gh merged commit 6abe0b4 into main Aug 28, 2026
207 of 224 checks passed
@rahulc-gh
rahulc-gh deleted the revert-6754-users/hsivasun/manifest-diff-pr-comment branch August 28, 2026 16:37
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants