Skip to content

ISSUE ID : 7729 skip uploading log files - #7723

Open
jonatluu wants to merge 5 commits into
mainfrom
users/jonatluu/log_fix
Open

ISSUE ID : 7729 skip uploading log files#7723
jonatluu wants to merge 5 commits into
mainfrom
users/jonatluu/log_fix

Conversation

@jonatluu

@jonatluu jonatluu commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Motivation

Packages location has logs being uploaded to it. Logs should be blocked from being uploaded there like how txt files are currently being blocked

therock-ci-artifacts.s3.amazonaws.com/33013518162-linux/packages/deb/index.html wrong because logs are being uploaded where packages should be

therock-ci-artifacts.s3.amazonaws.com/33013518162-linux/logs/packaging/index.html correct location for logs

Fixes: #7729

Technical Details

skip log files when uploading. Change upload_to_s3 function

Test Plan

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/packaging/linux/upload_package_repo.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 28, 2026
@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@raramakr

Copy link
Copy Markdown
Contributor

@jonatluu Pls create a corresponing Github issue and fix the pr-bot errors

@raramakr
raramakr force-pushed the users/jonatluu/log_fix branch from 2d6278e to 5c9480a Compare August 28, 2026 18:58
@raramakr raramakr added ci:host-asan Opt-in to running multi-arch host-asan CI on a pull request and removed ci:host-asan Opt-in to running multi-arch host-asan CI on a pull request labels Aug 28, 2026
@jonatluu jonatluu changed the title skip uploading log files ISSUE ID : 7729 skip uploading log files Aug 28, 2026
Comment on lines +299 to +302
# Skip log files - these are uploaded separately to logs/packaging/
if fname.lower().endswith(".log"):
print(f"Skipping log file (uploaded separately): {fname}")
continue

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also/instead change the log directory to not be nested under Path(config.dest_dir) and mixed with package outputs:

Or exclude logs/ instead of just *.log if there are other log files in the directory today or some time in the future

@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

[Issue]: Logs uploaded to incorrect location

3 participants