ISSUE ID : 7729 skip uploading log files - #7723
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
|
@jonatluu Pls create a corresponing Github issue and fix the pr-bot errors |
2d6278e to
5c9480a
Compare
| # Skip log files - these are uploaded separately to logs/packaging/ | ||
| if fname.lower().endswith(".log"): | ||
| print(f"Skipping log file (uploaded separately): {fname}") | ||
| continue |
There was a problem hiding this comment.
You could also/instead change the log directory to not be nested under Path(config.dest_dir) and mixed with package outputs:
TheRock/build_tools/packaging/linux/build_package.py
Lines 675 to 676 in 1fb7810
TheRock/build_tools/packaging/linux/upload_package_repo.py
Lines 344 to 347 in 1fb7810
Or exclude logs/ instead of just *.log if there are other log files in the directory today or some time in the future
Motivation
Packages location has logs being uploaded to it. Logs should be blocked from being uploaded there like how txt files are currently being blocked
therock-ci-artifacts.s3.amazonaws.com/33013518162-linux/packages/deb/index.html wrong because logs are being uploaded where packages should be
therock-ci-artifacts.s3.amazonaws.com/33013518162-linux/logs/packaging/index.html correct location for logs
Fixes: #7729
Technical Details
skip log files when uploading. Change upload_to_s3 function
Test Plan
Test Result
Submission Checklist