[ci] Split test requirements by subproject - #7728
Draft
ScottTodd wants to merge 8 commits into
Draft
Conversation
Install artifact-provided requirements for component tests and carry the configuration through failure reproduction commands. Remove the libhipcxx and TensileLite dependencies from the shared test environment. Tests: 52 passed in the targeted build_tools test suite. Generated with Codex
Always pass the component requirements list from the workflow and let the installer no-op when the list is empty. Generated with Codex
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This depends on the following PRs (included as submodule edits until reviewed/merged):
Motivation
We've been using a common https://github.com/ROCm/TheRock/blob/main/requirements-test.txt file across all ROCm subproject tests that seemed convenient to extend at the time, but it has a few drawbacks:
Technical Details
Important
Now each project that installs additional requirements should provide its own
requirements.txtas part of its test artifact and register that with the CI test system via theadditional_requirements_filesfield inbuild_tools/github_actions/fetch_test_configurations.py.Comparing https://github.com/ROCm/TheRock/actions/runs/33191445520 (this branch) vs a baseline https://github.com/ROCm/TheRock/actions/runs/33159247177, in aggregate across up to 50 subproject test jobs, this results in:
Test Plan
workflow_dispatch: https://github.com/ROCm/TheRock/actions/runs/33191445520 and checked that jobs complete successfully after installing the expected set of packagesSubmission Checklist