Skip to content

ci(jax): drop hardcoded Google DNS from wheel test containers - #7733

Open
amd-shiraz wants to merge 1 commit into
mainfrom
users/shiraz.ali/remove_dns_entry
Open

ci(jax): drop hardcoded Google DNS from wheel test containers#7733
amd-shiraz wants to merge 1 commit into
mainfrom
users/shiraz.ali/remove_dns_entry

Conversation

@amd-shiraz

@amd-shiraz amd-shiraz commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

These were a CloudFront/runner DNS workaround and should no longer be required.

Test plan

  • Confirm JAX wheel test workflows still start containers without the Google DNS flags
  • Confirm package/index fetches in those jobs resolve normally (no CloudFront/DNS regressions)

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 28, 2026
@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 28, 2026

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test_multi_arch_linux_jax_wheels.yml workflow should run as part of CI (e.g. https://github.com/ROCm/TheRock/actions/runs/33190869165/job/98953040597), so we could wait for signal before merge.

We can also trigger https://github.com/ROCm/TheRock/actions/workflows/test_multi_arch_linux_jax_wheels.yml with workflow_dispatch from this users/shiraz.ali/remove_dns_entry branch with the inputs from a job like that (https://github.com/ROCm/TheRock/actions/runs/33190869165/job/98953040597#step:1:22) to jump straight to the tests without waiting for builds to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

3 participants