[gfx1250] feat(mega_moe): add operand init modes and b2b timing knobs - #5163
Open
arakowsk-amd wants to merge 1 commit into
Open
[gfx1250] feat(mega_moe): add operand init modes and b2b timing knobs#5163arakowsk-amd wants to merge 1 commit into
arakowsk-amd wants to merge 1 commit into
Conversation
Adds a shared _init_data helper supporting zero/const/rand/norm operand init, wires it into make_shared_weights and the activation tensor, and exposes --init/--init-const CLI flags. Also adds --warmup/--iters so bench() can run averaged back-to-back graph replays. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_init_datahelper supportingzero/const/rand(uniform) /norm(gaussian) operand initialization, withrand/normhonoring the generator for reproducibility._init_dataintomake_shared_weightsand thex0activation tensor; expose--initand--init-constCLI flags.--warmupand--itersknobs soDeviceMoEPipeline.bench()can run averaged back-to-back (b2b) graph replays with a single sync at the end, instead of a single fixed replay.Test plan
python -m py_compile op_tests/multigpu_tests/test_mega_moe_gfx1250.py(passes locally)--init norm --iters 1path)--init const --init-const 1.0,--init zero,--iters 4 --warmup 10🤖 Generated with Claude Code