[Test] Add smoke test to cover new runtime envar #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kewen12
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
jplehr
reviewed
Jan 3, 2025
test/smoke-dev/rt-memory-threshold-env/AMDGPUMemoryManager_threshold_env.c
Show resolved
Hide resolved
saiislam
reviewed
Jan 27, 2025
|
@Kewen12 what's the status of this PR? |
This smoke test is to cover the new runtime envar OMPX_AMD_MEMORY_MANAGER_THRESHOLD_EXP_2 which is designed for users to specify the threshold for the memory size handled by AMDGPUMemoryManager.
Kewen12
force-pushed
the
test_memory_threshold_env
branch
from
73395a2 to
bd45742
Compare
oops, I missed the notification of the previous comment. Thanks for the reminder. Addressed comment. Please approve if it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This smoke test is to cover the new runtime envar OMPX_AMD_MEMORY_MANAGER_THRESHOLD_EXP_2 which is designed for users to specify the threshold for the memory size handled by AMDGPUMemoryManager.
Please merge after the internal patch was landed.