[AOMP] Add shellcheck workflow #1435
Open
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an initial (crude) shellcheck workflow. This can be refined much more. - Use shellcheck directly from maintainer github. - Filter which files to check. - Come up with set of guidelines / rules for errs/warns.
Use find + xargs to make the job fail in case shellcheck found issues.
|
This depends on #1252 and makes only sense once that has landed. |
dpalermo
requested changes
May 16, 2025
.github/workflows/aomp-shell.yml
Outdated
| - name: Set up shellcheck | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y shellcheck |
There was a problem hiding this comment.
I don't think we want to be running apt-get update & a possible install on every checkout of aomp. I would drop out this part. We can just install shellcheck as needed (I've added it to git/apps/openmp/sysadmin/install-3-other for new system setup/refresh)
There was a problem hiding this comment.
I agree with Dan. I added the install instructions to SOURCEINSTALL_PREREQUISITE.md
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.