Update TargetInfo.cpp #35
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling implicit kernel argument support for HIP.
|
Enabled the implicit kernel argument area for HIP as well. With this attribute enabled from clang, compiler backend adds the implicit arguments (48-Bytes) at the end of the actual user argument area. Since the implicit kernargs are inserted at the tail of the actual arguments, there is no change in the offset generated for the user parameters. Hence there won't be any break in the existing HIP tests with this commit. For the consumers of the implicit kernarg area, HIP runtime library should be modified to accommodate the implicit kernargs at runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling implicit kernel argument support for HIP.