Implement currentStackPtr for PowerPC64 #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runlevel5
requested review from
chrispaquot,
gandryey,
mangupta,
rakesroy and
saleelk
as code owners
Author
|
@classilla could you please help me review this Pull Request? Great thanks in advance |
|
As far as the code itself, it looks correct (can't vouch for completeness but this much looks right). |
Contributor
|
Imported to ROCm/rocm-systems |
|
@runlevel5 just a check here that didn't occur to me at the time (I'm not familiar with this package). Is this supposed to load the stack pointer, or return the current value of the stack pointer? If the former, it's correct. If the latter, then the operands should be reversed. |
Author
|
@classilla from my understanding it is the former |
Author
|
@classilla FYI the PR has been moved to ROCm/rocm-systems#473, please continue our conversations in the other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #61
Changes
Os::currentStackPtrNotes
This implementation should work with both Big and Little Endian