Skip to content

Conversation

@AviralGoelAMD
Copy link
Collaborator

Proposed changes

This PR adds a script that verifies that files to be committed have the correct copyright header.
Also updates the remod.py script with the new copyright header template.

Script is made part of precommit-hooks and would not let incorrect header formats be pushed to the repository.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged chore(copyright): update copyright header for include directory #3293

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@AviralGoelAMD
Copy link
Collaborator Author

@amd-anclark Please give me a review on .pre-commit-config.yaml and script/check_copyright_year.sh

amd-anclark
amd-anclark previously approved these changes Nov 26, 2025
Copy link
Collaborator

@amd-anclark amd-anclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked check_copyright_year.sh and .pre-commit-config.yaml files.

@AviralGoelAMD AviralGoelAMD requested a review from afagaj November 26, 2025 21:29
@AviralGoelAMD AviralGoelAMD force-pushed the aviralgoel/update_copyright_final branch from 3aaf167 to cc1e20e Compare November 29, 2025 00:08
@AviralGoelAMD AviralGoelAMD force-pushed the aviralgoel/update_copyright_final branch from 5401e4b to 86ad7d2 Compare November 29, 2025 01:13
@AviralGoelAMD AviralGoelAMD self-assigned this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants