-
Notifications
You must be signed in to change notification settings - Fork 256
Wmma support for gemm_bias_add_reduce #3316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
||
| void add_device_gemm_bias_add_mean_squaremean_wmma_cshuffle_f16_f16_f16_f16_f16_f32_f32_km_nk_mn_instances( | ||
| std::vector<DeviceGemmBiasAddReduceNoOpPtr>&); | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not just use the instance factory get_device_gemm_add_add_mean_squaremean_instances() here instead of manually using the add_device_xxx_instances() functions?
|
In the profiler impl we have: But I thought the Bias was a simple 1D vector of size N? |
| make_tuple(I0, I0, I0, I0), | ||
| c01_thread_buf); | ||
|
|
||
| // c = c + c1_functior(c1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo
|
|
||
| public: | ||
| static constexpr bool verify_ = true; | ||
| static constexpr int init_method_ = 1; // decimal value initialization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is int value initialization
90fa9e7 to
7cd0696
Compare
Proposed changes
Summary:
EpilogueReduceCShuffleto support bias + add operations before reduction (multiple Ds)gemm_bias_add_reduceChecklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered