Skip to content

Do not use GTEST_BOTH_LIBRARIES variable. #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Do not use GTEST_BOTH_LIBRARIES variable. #1931

wants to merge 1 commit into from
+2 −2

Conversation

stellaraccident
Copy link
Contributor

  • This is a legacy variable that is not recommended for modern use and is only available via the GTest find module, not the actual config provided by the package.
  • Recommended usage is just to depend on the libraries.
  • Also removes GTEST_INCLUDE_DIRS, since that is implicit in depending on the library.

Fixes ROCm/TheRock#414

@stellaraccident
Do not use GTEST_BOTH_LIBRARIES variable.
800b902 
* This is a legacy variable that is not recommended for modern use and is only available via the GTest find module, not the actual config provided by the package.
* Recommended usage is just to depend on the libraries.
* Also removes GTEST_INCLUDE_DIRS, since that is implicit in depending on the library.

Fixes ROCm/TheRock#414
@stellaraccident stellaraccident mentioned this pull request Apr 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

@aazz44ss aazz44ss Awaiting requested review from aazz44ss aazz44ss is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hipBLASLt] Do not use GTEST_BOTH_LIBRARIES variable.
1 participant
@stellaraccident