Slaurenz therock win stage #1956
Draft
+155
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
force-pushed
the
slaurenz_therock_win_stage
branch
2 times, most recently
from
5e16655 to
804c9d1
Compare
Adapted from: https://github.com/msgpack/msgpack-c/wiki/Q%26A#how-to-support-both-msgpack-c-c-version-5x-and-6x- Note that 6.x also defines compile definitions that must be respected.
…onfigure time PATH. * Makes gen_assembly.sh and compile_code_object.sh scripts fail on error vs silently succeeding (`set -e`). These scripts have a suspect design overall, but making them error on failure is a minimal thing that is needed. * Do not hard-code /opt/rocm tooling paths in these shell scripts. Instead use an explicit `ROCM_PATH` if specified, falling back to `PATH` resolution like the rest of the project. This is still looser than I would like (I would prefer explicit configuration of tools), but this at least makes things work. We should never have hard-coded /opt/rocm paths in scripts. * Wraps build time tool invocation in `cmake -E env PATH=...` to propagate the configure time PATH to build time. Otherwise, this project cannot build with separate configure/build environments, which is a standard practice for assembling super-projects. * Escapes the PATH environment variable so it is suitable to pass to COMMANDs on either platform. * On Windows, also validates that `bash` is a usable native bash vs the WSL system bash that MSFT installs by default and is incompatible with native tooling. In general, hipBLASLt is very sloppy in terms of how it finds its tools. I resisted the urge to attempt to clean that up because the refactoring would need to be quite extensive. This is a minimal set of changes to at least make what was written correct. This will have a subtle change that if the project was not build with an explicit ROCM_PATH and was somehow relying on falling back to /opt/rocm implicitly, that will now fail. As it should.
Use the config files provided by upstream instead of a custom finder.
So far it is assumed that NETLIB BLAS and LAPACK are avilable without checking. If they are nore, the build fails when trying to link. Switches to `find_package()` therefore which also enables using OpenBLAS.
When using setuptools>=71.0.0 and packaging<22.0, setuptools may fail with `TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'`.
* Pinning clocks was already conditioned on this, so the cleanup logic should also be.
* This is a legacy variable that is not recommended for modern use and is only available via the GTest find module, not the actual config provided by the package. * Recommended usage is just to depend on the libraries. * Also removes GTEST_INCLUDE_DIRS, since that is implicit in depending on the library.
This patch is not to be landed but just makes some coarse changes to the legacy CMake files to let them configure/build at all on Windows. Actual Windows support will target the new CMake build files being written now.
stellaraccident
force-pushed
the
slaurenz_therock_win_stage
branch
from
804c9d1 to
b4f4cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.