Add support for single wave stream-k kernels #1975
Open
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBrownAMD
requested review from
babakpst,
mahmoodw,
daineAMD,
msujon-AMD and
hliuca
AlexBrownAMD
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh,
solaslin and
aazz44ss
as code owners
msujon-AMD
reviewed
Apr 23, 2025
| @@ -265,6 +268,9 @@ BenchmarkProblems: | |||
| - [16, 16, 16, 1, 1, 1,4, 2,2] | |||
| - [16, 16, 16, 1, 1, 1,2, 2,2] | |||
| - [16, 16, 16, 1, 1, 1,1, 2,2] | |||
| - [16, 16, 16, 1, 1, 1,1, 2,1] | |||
| - [16, 16, 16, 1, 1, 1,1, 1,2] | |||
| - [16, 16, 16, 1, 1, 1,1, 1,1] | |||
There was a problem hiding this comment.
Will this change support this MFMA but with LSU=4 (e.g., - WorkGroup:[4,4,4]?
If so, pls add test with 2x1 or 1x2 waves with LSU=2 and 1x1 waves with LSU=2 and 4.
| @@ -756,6 +756,11 @@ def partialsWriteBatch(self, writer, kernel, ss, batchIdx, applyAlpha, beta, edg | |||
| module.add(VMovB32(vgpr(cvtVgprStruct.vgprBF8Max), "0x47600000", comment="BF8 Max value 57344 as float32" )) | |||
| module.add(VMovB32(vgpr(cvtVgprStruct.vgprBF8Min), "0xc7600000", comment="BF8 Min value -57344 as float32" )) | |||
|
|
|||
| if kernel["EnableMatrixInstruction"]: | |||
| WaveNum = kernel["MIWaveGroup"][0] * kernel["MIWaveGroup"][1] | |||
There was a problem hiding this comment.
do we need to consider LSU to compute wave count here as well?
hliuca
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow wavegroup to be less than 4 in stream-k kernels. This change updates the partials and fixup code to tkae number of waves into account.
Added new test cases to the hgemm stream-k unit tests for wave groups (2,1), (1,2), and (1,1).