Enable mbsk spmm #2119
Merged
Enable mbsk spmm #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vin-huang
commented
May 24, 2025
vin-huang
commented
- Added requiredSynchornizerSizes()
- Enable MBSK for SPMM
- Add MBSK test for SPMM
vin-huang
force-pushed
the
enable_mbsk_spmm
branch
4 times, most recently
from
d3cb107 to
94935bb
Compare
vin-huang
requested review from
jichangjichang,
KKyang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh,
solaslin and
aazz44ss
as code owners
|
The Azure CI was failed due to cannot find proper device. Hip error: 'no ROCm-capable device is detected'(100) at /agent/_work/1/s/library/src/amd_detail/hipblaslt.cpp:171 |
KKyang
reviewed
May 27, 2025
vin-huang
force-pushed
the
enable_mbsk_spmm
branch
2 times, most recently
from
90eaf6b to
c1c8201
Compare
KKyang
previously approved these changes
May 28, 2025
…r size for the MBSK kernel.
* Add refineOccupancy to set the proper occupancy limit. * Allocated the required SGPRs needed by storeRemapAddStore() before calculating occupancy.
vin-huang
force-pushed
the
enable_mbsk_spmm
branch
from
c1c8201 to
c189be1
Compare
| @@ -867,14 +867,19 @@ def GSUSynccodegen(self, writer, kernel, tmpVgpr, tmpVgprSize, tmpVgprDynamic, b | |||
| vmcnt = SyncloadedData = SyncloadedData -1 | |||
| module.add(SWaitCnt(lgkmcnt=lgkmcnt, vmcnt=vmcnt, vscnt=vscnt, comment="(wait for buffer ready)")) | |||
|
|
|||
| if ((gwvw % 2) == 1): | |||
| if kernel["ProblemType"]["DataType"].isInt8() or kernel["ProblemType"]["DataType"].isInt32(): | |||
There was a problem hiding this comment.
should we check kernel["ProblemType"]["ComputeDataType"].isInt32() ?
There was a problem hiding this comment.
In the original case, which didn't consider the output datatype is int32 from mfma/smfma instruction.
So, here I use kernel["ProblemType"]["DataType"] to identify the output datatype.
jichangjichang
approved these changes
Jun 3, 2025
KKyang
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.