-
Notifications
You must be signed in to change notification settings - Fork 137
Origami solution selection #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origami solution selection #2126
Conversation
We have both select_best_macro_tile_size and select_best_grid_size. Will we use predict MT and Gridbased combination in the future? |
select_best_macro_tile_size : Determines the Macro Tile dimensions and DepthU (Internally called MT_M,MT_N,MT_K) select_best_grid_size : Is an example of a dynamic mode for streamk, this is used to predict the number of workgroups it's best to launch for streamk, which then determines StreamK's splitting. |
There are two slightly conflicting declarations of |
tensilelite/Tensile/Source/lib/include/Tensile/PredictionLibrary.hpp
Outdated
Show resolved
Hide resolved
This is legacy code that was determined to be too slow. Will Remove |
0bb4277
to
261685f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few minor comments with regards to the TensileCreateLibrary code.
tensilelite/Tensile/Source/lib/source/analytical/AnalyticalGemm.cpp
Outdated
Show resolved
Hide resolved
Perhaps you should add a description for Is |
I think that we wanted to move from TENSILE_STREAMK_DYNAMIC_GRID=3 as the default to either 4 or 5. Thoughts @AlexBrownAMD ? I can also add Descriptions where you mentioned. |
I think we should start using |
b897c6e
This will Impact all streamk kernels though right? Should we check other libraries being built with StreamK function well with this before changing it? |
tensilelite/Tensile/Source/lib/include/Tensile/PredictionLibrary.hpp
Outdated
Show resolved
Hide resolved
…ry.hpp Co-authored-by: Bryant Nelson <[email protected]>
Add a new solution selection mechanism using the Origami library to select the best performing kernel.
This PR does not include any Origami library logic files. Sample libraries are available, and initial libraries will be checked in later in a separate PR.