Skip to content

[hipCUB] Increase code coverage #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
aecb683
implemented missing inclusive sum tests
NguyenNhuDi Apr 21, 2025
760ef4b
implemented additional unit tests for inclusive/exclusive sum
NguyenNhuDi Apr 21, 2025
734d57a
implemented addition unit tests for functions with 1 parameter
NguyenNhuDi Apr 29, 2025
bae1725
implemented missing unit test for scatter_to_striped_guarded
NguyenNhuDi Apr 29, 2025
f14e278
implemented missing unit test for BlockedToWarpStriped one param
NguyenNhuDi Apr 29, 2025
fa1b5ca
implemented missing unit test for ScatterToBlocked with no output param
NguyenNhuDi Apr 29, 2025
8560ccf
implemented missing unit test for ScatterToStriped with not output param
NguyenNhuDi Apr 29, 2025
df52946
implemented missing unit test for ScatterToStripedGuarded with not ou…
NguyenNhuDi Apr 29, 2025
2f8f0d7
implemented missing unit test for ScatterToStripedFlagged
NguyenNhuDi Apr 29, 2025
10ac4eb
implemented missing unit test for ScatterToStripedFlagged with not ou…
NguyenNhuDi Apr 29, 2025
601912f
fixed ScatterToStripedFlagged with no output param to call the correc…
NguyenNhuDi Apr 29, 2025
546a701
updated changelog
NguyenNhuDi Apr 29, 2025
9267532
implemented sort with oob_default and stable sort
NguyenNhuDi May 2, 2025
24d257f
implemented unit test for StableSort with Keys and valus
NguyenNhuDi May 2, 2025
fc39620
implemented unit test for stable sort with valid items
NguyenNhuDi May 2, 2025
56298eb
implemented additional unit test for StableSortKeysValue with Valid I…
NguyenNhuDi May 5, 2025
47b50c4
updated changelog
NguyenNhuDi May 5, 2025
098213f
implemented unit tests for RankKeys with exclusive_digit_prefix param…
NguyenNhuDi May 7, 2025
76df1ab
updated test paramaters to be more consistent
NguyenNhuDi May 7, 2025
dd6e401
implemented additional parameters to cover all functions in radix sort
NguyenNhuDi May 8, 2025
0025e6f
updated Changelog
NguyenNhuDi May 8, 2025
1b2470d
updated CHANGELOG to include updates on block radix rank
NguyenNhuDi May 8, 2025
fb9bcf3
implemented missing unit tests for sum functions in reduce
NguyenNhuDi May 8, 2025
d0d09dc
updated changelog
NguyenNhuDi May 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ Full documentation for hipCUB is available at [https://rocm.docs.amd.com/project
* Added an overload of `WarpScan::InclusiveScan` that accepts an initial value to seed the scan.
* `UnrolledThreadLoad`, `UnrolledCopy`, and `ThreadLoadVolatilePointer` were added to align hipCUB with CUB.
* `ThreadStoreVolatilePtr` and the `IterateThreadStore` struct were added to align hipCUB with CUB.
* Additional unit tests for `InclusiveSum` and `ExclusiveSum` in `test/hipcub/test_hipcub_block_scan.cpp`.
* Additional unit tests for functions in `BlockExchange` class located in `test/hipcub/test_hipcub_block_exchange.cpp`.
* Additional unit tests for functions in `BlockMergeSortStrategy` class located in `test/hipcub/test_hipcub_block_merge_sort.cpp`.
* Additional unit tests for functions in `BlockRadixRank` class located in `test/hipcub/test_hipcub_block_radix_rank.cpp`.
* Additional unit tests for functions in `BlockRadixSort` class located in `test/hipcub/test_hipcub_block_radix_sort.cpp`.
* Additional unit tests for functions in `BlockReduce` class located in `test/hipcub/test_hipcub_block_reduce.cpp`.

### Changed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ class BlockExchange
OffsetT (&ranks)[ITEMS_PER_THREAD], ///< [in] Corresponding scatter ranks
ValidFlag (&is_valid)[ITEMS_PER_THREAD]) ///< [in] Corresponding flag denoting item validity
{
ScatterToStriped(items, items, ranks, is_valid);
ScatterToStripedFlagged(items, items, ranks, is_valid);
}

#endif // DOXYGEN_SHOULD_SKIP_THIS
Expand Down
Loading
Loading