Feat/requirements from common - #6620
Draft
neon60 wants to merge 7 commits into
Draft
Conversation
alexxu-amd
approved these changes
Aug 19, 2026
alexxu-amd
left a comment
alexxu-amd
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Minor point: once rocm-docs-common is ready, we can use tag instead of main for improved reproducibility.
Point docs/sphinx/requirements.txt at the pinned lockfile in rocm-docs-common over HTTPS, so a local build needs no clone. A commented local-path override is provided for building against a rocm-docs-common checkout. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Pull the pinned Sphinx build dependencies (and the matching rocm-docs-core branch) from the shared rocm-docs-common lockfile over HTTPS. Requirements must be available at pip time, so they come from the URL rather than the build-time common-data clone. Divergence is documented inline: comment the -r URL and add local pins or point at a local checkout. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
rocm-docs-core clones rocm-docs-common into the repo root at build time to read shared data locally; keep that checkout out of version control. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Add a post_checkout job that clones rocm-docs-common before dependency install, and point python.install at that checkout's Sphinx lockfile instead of downloading it over HTTPS. rocm-docs-core reuses the same clone for its shared data at build time. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
…oint Point .readthedocs.yaml at the repo's own docs/sphinx/requirements.txt and have the post_checkout job rewrite its default HTTPS -r line to the cloned rocm-docs-common lockfile, avoiding the HTTPS fetch on Read the Docs. A customized requirements.txt (URL line removed) is left untouched and used verbatim locally and on RTD. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Read the Docs executes each post_checkout job step under dash, which mangled the multi-line if...fi literal block and failed with "Syntax error: end of file unexpected (expecting \"fi\")". Collapse the conditional onto one line so it runs correctly. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
The one-line if...fi still failed under Read the Docs' shell with "Syntax error: end of file unexpected (expecting \"fi\")", and the sed used # as its delimiter, which the shell also mangled. Replace it with a bare sed that uses @ as the delimiter and has no spaces in the expression. It is a no-op when the default URL is absent, so a customized requirements.txt is still left untouched, without needing a conditional. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
neon60
force-pushed
the
feat/requirements-from-common
branch
from
August 28, 2026 10:54
44ba28f to
9bcbbe6
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist