Skip to content

docs: redirect governance to TheRock and fix grammar - #6640

Open
neon60 wants to merge 1 commit into
developfrom
minor_update_related_therock
Open

docs: redirect governance to TheRock and fix grammar#6640
neon60 wants to merge 1 commit into
developfrom
minor_update_related_therock

Conversation

@neon60

@neon60 neon60 commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Motivation

Governance for ROCm is now maintained in TheRock, the build and release system for ROCm, alongside the code of conduct. To avoid two diverging copies, this repo's GOVERNANCE.md should stop hosting the full model and instead redirect readers to the canonical document. This PR reduces GOVERNANCE.md to a short redirect stub and fixes a small grammar error in what-is-rocm.rst while touching nearby docs.

Technical Details

  • GOVERNANCE.md — Replaced the full governance model with a short stub:
    • A highlighted > [!IMPORTANT] "This document has moved" callout linking to
      ROCm/TheRock/GOVERNANCE.md.
    • One-line statement that ROCm is led by AMD and that governance/code of conduct now live in TheRock, plus a "ROCm Project Governance" link to the canonical doc.
    • <head> meta updated: description now says the model has moved, keywords adds TheRock, plus <meta name="robots" content="noindex"> and <link rel="canonical" href="https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md"> so search engines drop the stub in favor of the canonical page.
  • docs/about/what-is-rocm.rst — Dropped a stray article: "built through the TheRock" → "built through TheRock".

Related: the canonical governance doc is added to TheRock in a companion change (ROCm/TheRock branch users/neon60/make_therock_top).

Test Plan

  • Build the docs locally and confirm no new Sphinx warnings/errors: 
    python -m sphinx -T -E -b html -d _build/doctrees -D language=en docs _build/html
  • Verify the what-is-rocm page renders "built through TheRock" with the TheRock hyperlink intact.
  • Confirm the GOVERNANCE.md moved-warning and canonical link resolve.

Test Result

  • Grammar fix verified in a prior local HTML build: the what-is-rocm page renders "is built through TheRock" (article removed, link intact).
  • GOVERNANCE.md links reviewed manually and point at the canonical ROCm/TheRock/GOVERNANCE.md.
  • Not verified: how the meta (noindex/canonical) renders through Sphinx/MyST — raw HTML in a MyST .md may be emitted into the page body rather than the document , so the noindex may not take effect until confirmed in the built output. Recommend a build check before relying on it for SEO.

Submission Checklist

@neon60 @claude
docs: redirect governance to TheRock and fix grammar
b621e57 
Replace GOVERNANCE.md with a short stub pointing to the canonical
governance doc in TheRock (with a moved warning, noindex, and canonical
link), and drop a stray article in what-is-rocm.rst.

Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
@neon60
neon60 marked this pull request as ready for review August 28, 2026 15:27
@neon60
neon60 requested a review from a team as a code owner August 28, 2026 15:27
@neon60
neon60 requested a review from saadrahim August 28, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes
@randyh62 randyh62 randyh62 approved these changes
@peterjunpark peterjunpark peterjunpark approved these changes
@saadrahim saadrahim Awaiting requested review from saadrahim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neon60 @ScottTodd @randyh62 @peterjunpark