Skip to content

[WaveTransform] Fix FileCheck patterns for more tests#2691

Open
cdevadas wants to merge 1 commit into
amd-feature/wave-transformfrom
public/amd/dev/cdevadas/wave-transform/fix-more-control-flow-tests
Open

[WaveTransform] Fix FileCheck patterns for more tests#2691
cdevadas wants to merge 1 commit into
amd-feature/wave-transformfrom
public/amd/dev/cdevadas/wave-transform/fix-more-control-flow-tests

Conversation

@cdevadas
Copy link
Copy Markdown

@cdevadas cdevadas commented May 27, 2026

Fixed the check patterns for some more control flow tests
when enabled the wave transform flow.

Tests fixed in this commit:

  • mdt-preserving-crash.ll
  • memcpy-crash-issue63986.ll
  • memmove-var-size.ll
  • memory-legalizer-single-wave-workgroup-memops.ll
  • memset-param-combinations.ll
  • memset-pattern.ll
  • mfma-loop.ll
  • mfma-no-register-aliasing.ll
  • misaligned-vgpr-regsequence.mir
  • mmra.ll

Disabled late wave transform:

  • lower-control-flow-live-variables-update.xfail.mir.
    Disabled wave transform (-amdgpu-late-wave-transform=0)
    since test expects legacy SI_IF/SI_END_CF pseudos which
    are incompatible with wave transform.

@z1-cciauto
Copy link
Copy Markdown
Collaborator

@lalaniket8
Copy link
Copy Markdown

There seems to be overlap in tests covered in PR #2625

Fixed the check patterns for some more control flow tests
when enabled the wave transform flow.

Tests fixed in this commit:
- mdt-preserving-crash.ll
- memcpy-crash-issue63986.ll
- memmove-var-size.ll
- memory-legalizer-single-wave-workgroup-memops.ll
- memset-param-combinations.ll
- memset-pattern.ll
- mfma-loop.ll
- mfma-no-register-aliasing.ll
- misaligned-vgpr-regsequence.mir
- mmra.ll

Disabled late wave transform:
- lower-control-flow-live-variables-update.xfail.mir.
  Disabled wave transform (-amdgpu-late-wave-transform=0)
  since test expects legacy SI_IF/SI_END_CF pseudos which
  are incompatible with wave transform.
@cdevadas cdevadas force-pushed the public/amd/dev/cdevadas/wave-transform/fix-more-control-flow-tests branch from bcf113d to d582358 Compare May 27, 2026 17:31
@cdevadas
Copy link
Copy Markdown
Author

There seems to be overlap in tests covered in PR #2625

Removed the duplicates in the new commit.

@z1-cciauto
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants