Reapply "clang: Refactor handling of offload sanitizer arguments (#196737)"#2692
Open
lamb-j wants to merge 3 commits into
Open
Reapply "clang: Refactor handling of offload sanitizer arguments (#196737)"#2692lamb-j wants to merge 3 commits into
lamb-j wants to merge 3 commits into
Conversation
ASAN on AMDGPU requires xnack+. After clang llvm#196737, getSupportedSanitizers correctly excludes Address for arches without xnack+, so the test must request it explicitly.
Collaborator
Author
|
Self note: Try to remember to merge not squash this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapply upstream llvm#196737 (originally reverted in 73d4899 for breaking the Comgr asan test), fix the Comgr test, and revert PR #1334.
PR #1334 ("[ASan][OpenMP] Fix OpenMP ASan driver and device-rtl build") added an
AMDGPUToolChainctor-timegetSanitizerArgs(Args)call with noBoundArch/OffloadKind. After the reapply, that call hits the newOFK_Nonehard-error path and silences the later correct call fromClang.cpp— turningwarning: ignoring 'leak' in '-fsanitize=leak'intoerror: unsupported option '-fsanitize=leak'. Matt Arsenault flagged this exact regression on the #1334 review and asked it not be carried out-of-tree; the upstream replacement (llvm#179636) is still open pending Multilib infrastructure.Locally verified all three previously-failing tests pass with this stack:
Clang :: Driver/amdgpu-openmp-sanitize-options.c,Clang :: Driver/hip-sanitize-options.hip,Comgr :: compile-asan.hip.