[Clang][OpenMP] Deprecate -fopenmp-target-xteam-scan and -fopenmp-target-xteam-no-loop-scan#2704
Open
nicebert wants to merge 1 commit into
Open
[Clang][OpenMP] Deprecate -fopenmp-target-xteam-scan and -fopenmp-target-xteam-no-loop-scan#2704nicebert wants to merge 1 commit into
nicebert wants to merge 1 commit into
Conversation
…get-xteam-no-loop-scan Emit a deprecation warning when either flag (or its -fno- partner) is passed. The flags and their implementation will be removed once the upstream cross-team reduction rewrite lands in amd-staging. Also drop the staging-only tests that exercise these flags.
|
there is also the https://github.com/ROCm/llvm-project/tree/6d43f828613a6b15b0ad92333108679754846429/offload/test/xteams directory which should be removed |
There was a problem hiding this comment.
Let' s change the deprecation message to something like:
"will be removed in a future revision of the OpenMP implementation."
ro-i
reviewed
May 28, 2026
| else | ||
| CmdArgs.push_back("-fno-openmp-target-multi-device"); | ||
|
|
||
| for (Arg *A : Args.filtered(options::OPT_fopenmp_target_xteam_scan, |
There was a problem hiding this comment.
shouldn't we do that on the arg definitions instead of filtering later?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit a deprecation warning when either flag (or its -fno- partner) is
passed. The flags and their implementation will be removed once
the upstream cross-team reduction rewrite lands in amd-staging.
Also drop the staging-only tests that exercise these flags.