Skip to content

[Clang][OpenMP] Deprecate -fopenmp-target-xteam-scan and -fopenmp-target-xteam-no-loop-scan #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicebert wants to merge 1 commit into
base: amd-staging
Choose a base branch
from
Open

[Clang][OpenMP] Deprecate -fopenmp-target-xteam-scan and -fopenmp-target-xteam-no-loop-scan #2704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clang/lib/Driver/ToolChains/Clang.cpp
View file
Open in desktop
Copy link
Copy Markdown

@CatherineMoore CatherineMoore May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let' s change the deprecation message to something like:

"will be removed in a future revision of the OpenMP implementation."

Original file line number Diff line number Diff line change
Expand Up @@ -7058,6 +7058,14 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
else
CmdArgs.push_back("-fno-openmp-target-multi-device");

for (Arg *A : Args.filtered(options::OPT_fopenmp_target_xteam_scan,
Copy link
Copy Markdown

@ro-i ro-i May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we do that on the arg definitions instead of filtering later?

options::OPT_fno_openmp_target_xteam_scan,
options::OPT_fopenmp_target_xteam_no_loop_scan,
options::OPT_fno_openmp_target_xteam_no_loop_scan))
D.Diag(diag::warn_drv_deprecated_custom)
<< A->getAsString(Args)
<< "will be removed once the cross-team reduction rewrite is merged from upstream";

if (Args.hasFlag(options::OPT_fopenmp_target_xteam_scan,
options::OPT_fno_openmp_target_xteam_scan, false))
CmdArgs.push_back("-fopenmp-target-xteam-scan");
Expand Down
4,288 changes: 0 additions & 4,288 deletions clang/test/OpenMP/xteam_scan_codegen.cpp
View file
Open in desktop

This file was deleted.

5,346 changes: 0 additions & 5,346 deletions clang/test/OpenMP/xteam_scan_datatypes.cpp
View file
Open in desktop

This file was deleted.

2,583 changes: 0 additions & 2,583 deletions clang/test/OpenMP/xteam_scan_host_codegen.cpp
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions clang/test/OpenMP/xteam_scan_messages.cpp
View file
Open in desktop

This file was deleted.

124 changes: 0 additions & 124 deletions offload/test/offloading/xteam_scan_1.c
View file
Open in desktop

This file was deleted.

Loading
Loading