[Comgr] Fix SPIR-V triple typo in setIsaName#2712
Merged
Merged
Conversation
The short-circuit in amd_comgr_action_info_set_isa_name checked for "spir64-..." but the canonical HIP SPIR-V triple is "spirv64-..." (LLVM Triple::spirv64), matching parseTargetIdentifier (SWDEV-533122) and the strings CLR passes in. Introduced as a typo in 967115f. Also fix misplaced space in "StringRef(IsaName )==".
chinmaydd
approved these changes
May 29, 2026
Collaborator
Author
|
!PSDB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short-circuit in
amd_comgr_action_info_set_isa_namechecked forspir64-...but the canonical HIP SPIR-V triple isspirv64-...(LLVMTriple::spirv64) — matchingparseTargetIdentifier(SWDEV-533122) and the strings CLR passes in. Introduced as a typo in 967115f.Dead code on real inputs: nothing in CLR or the LLVM amd subtree passes
spir64-amd-amdhsa-...amdgcnspirv. Fix aligns the two Comgr call sites with clang and CLR.Discovered while reviewing #2710.