[Infra][Nightly] Temp cherry-pick 2719 for hipcc and hiprtc test#2727
Open
kirthana14m wants to merge 1 commit into
Open
[Infra][Nightly] Temp cherry-pick 2719 for hipcc and hiprtc test#2727kirthana14m wants to merge 1 commit into
kirthana14m wants to merge 1 commit into
Conversation
kasaurov
reviewed
May 29, 2026
| run: | | ||
| cd compiler/amd-llvm | ||
| git fetch origin pull/2719/head:pr-2719 | ||
| git cherry-pick pr-2719 |
There was a problem hiding this comment.
Wondering wouldn't be better to add error handling (in the future the PR and the tip can diverge). Something like
if git cherry-pick pr-2719 --no-edit; then
cd ../..
git add compiler/amd-llvm
git commit -m "Update amd-llvm submodule with PR 2719"
else
echo "::warning::Cherry-pick of PR 2719 failed (likely conflicts). Skipping temp fix."
git cherry-pick --abort
fi
There was a problem hiding this comment.
On the other hand I think stopping the build is fine
kasaurov
approved these changes
May 29, 2026
| run: | | ||
| cd compiler/amd-llvm | ||
| git fetch origin pull/2719/head:pr-2719 | ||
| git cherry-pick pr-2719 |
There was a problem hiding this comment.
On the other hand I think stopping the build is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.