[AMDGPU][COMGR] Install gfx125x entry trampolines with hotswap#3000
Draft
harsh-amd wants to merge 8 commits into
Draft
[AMDGPU][COMGR] Install gfx125x entry trampolines with hotswap#3000harsh-amd wants to merge 8 commits into
harsh-amd wants to merge 8 commits into
Conversation
This was referenced Jun 21, 2026
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
4905511 to
02c967b
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
02c967b to
fe6deae
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
fe6deae to
3c1d9b2
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
3c1d9b2 to
9eba7e5
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE ID: SWDEV-499597
Summary
AMD_COMGR_HOTSWAP_ENTRY_TRAMPOLINES.comgr-hotswap-entry-trampoline.cpp.llvm::object::ELFFile<>for grown-image ELF symbol traversal when adjusting symbol values, matching the COMGR agent conventions.libamd_comgr_hotswap_tool.so.libhsa-hotswap.so.Paired PRs
Testing
git diff --checkASAN_OPTIONS=use_sigaltstack=0 cmake --build build-comgr-asan --target amd_comgr HotswapElfTests HotswapMCTests hotswap-rewrite --parallel 32ASAN_OPTIONS=use_sigaltstack=0 build-comgr-asan/test-unit/HotswapElfTestsASAN_OPTIONS=use_sigaltstack=0 build-comgr-asan/test-unit/HotswapMCTests --gtest_filter="BuildKernelEntryTrampoline.*"ASAN_OPTIONS=use_sigaltstack=0 build-llvm/bin/llvm-lit -sv build-comgr-asan/test-lit/hotswap-elf-growth.s build-comgr-asan/test-lit/hotswap-kernel-entry-trampoline.s build-comgr-asan/test-lit/hotswap-kernel-entry-trampoline-multi.s build-comgr-asan/test-lit/hotswap-barrier-isfirst.sASAN_OPTIONS=use_sigaltstack=0 cmake --build build-comgr-asan --target check-comgr --parallel 32ASAN
check-comgrpassed onmi350-4ate199f875ac611dfa82e4ce7ffb1f4c89e008fa44: lit reported 70 passed / 11 unsupported, CTest reported 31/31 passed, andHotswapElfTestsreported 6/6 passed.