fix: only define true/false for C in bnxt_re_hsi.h - #457
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents bnxt_re_hsi.h from redefining true/false when included from C++ translation units, which can break subsequent C++ parsing during MORI’s Bazel/XLA build work.
Changes:
- Guard
true/falsemacro definitions so they are only emitted for C (not C++). - Avoid redefining
true/falseif they are already defined (e.g., via<stdbool.h>). - Add an explanatory comment documenting the rationale and failure mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jhchouuu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue has popped up during MORI bazelification for XLA