[release/2.9] Fix int4mm device memcpy error on Windows (#175410)#3166
Merged
jeffdaily merged 1 commit intorelease/2.9from Apr 20, 2026
Merged
Conversation
On Windows with HIP/ROCm, std::memcpy is a __host__ function and cannot be called from __device__ code. Use raw memcpy (which the HIP compiler provides as a device builtin) when building on Windows. This will allow builds for of pytorch for gfx942 on Windows. gfx950 is yet to be tested but it should likely build as well. Pull Request resolved: pytorch#175410 Approved by: https://github.com/jeffdaily
jeffdaily
deleted the
release/2.9_cp_0f60458c8ecafe0168363347cfecefdfb7dd8489
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows with HIP/ROCm, std::memcpy is a host function and cannot be called from device code. Use raw memcpy (which the HIP compiler provides as a device builtin) when building on Windows.
This will allow builds for of pytorch for gfx942 on Windows. gfx950 is yet to be tested but it should likely build as well.
Pull Request resolved: pytorch#175410
Approved by: https://github.com/jeffdaily