[release/2.11] Windows specific test fixes (#176024)#3182
Merged
jeffdaily merged 1 commit intorelease/2.11from Apr 28, 2026
Merged
[release/2.11] Windows specific test fixes (#176024)#3182jeffdaily merged 1 commit intorelease/2.11from
jeffdaily merged 1 commit intorelease/2.11from
Conversation
|
Jenkins build for 5e583dbf0a5144e8d111ffd3e985d92bb1942f03 commit finished as FAILURE Detected error during Pytorch building: |
tvukovic-amd
force-pushed
the
windows_test_skips
branch
from
5e583db to
077f1a2
Compare
|
Jenkins build for 077f1a20e8ff09cc96f6cf5b0cf81213a459b93a commit finished as FAILURE Detected error during Pytorch building: |
jeffdaily
changed the title
This change includes test fixes specific to Windows: 1. cpp_extensions need flag `-DUSE_CUDA` when compiling with nvcc, otherwise runs into `'std': ambiguous symbol` errors when compiling on windows 2. Skip test_fake_export on Windows. It calls `get_device_capability()` with 0 cuda devices. On linux it passes but it asserts with "invalid device_id" on Windows. Different behavior on Windows vs Linux 3. test_serialize imports `has_triton` when only on GPU, but file uses it for other devices too 4. test_nep50_examples: Need to adjust expectation given how scalars are interpreted on Windows vs Linux 5. test_fx: Set correct expectation for call stack on Windows Pull Request resolved: pytorch#176024 Approved by: https://github.com/albanD, https://github.com/malfet Co-authored-by: PyTorch MergeBot <pytorchmergebot@users.noreply.github.com> Co-authored-by: Nikita Shulga <nshulga@meta.com>
jeffdaily
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of pytorch#176024